From: Jakub Narebski <jnareb@gmail.com>
To: Junio Hamano <junkio@cox.net>, Luben Tuikov <ltuikov@yahoo.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: tree view: hash_base and hash are now context sensitive
Date: Fri, 29 Sep 2006 22:35:27 +0200 [thread overview]
Message-ID: <200609292235.27478.jnareb@gmail.com> (raw)
In-Reply-To: <20060929161619.24848.qmail@web31806.mail.mud.yahoo.com>
Luben Tuikov wrote:
> --- Junio C Hamano <junkio@cox.net> wrote:
> > > What are the objections to this patch?
> >
> > No objections from me --- rather lack of objections from Jakub ;-)
>
> We haven't heard anything from him, and on our last correspondence
> in this thread it seemed we're in agreement.
As a interim solution it is a good idea, moreover with using $hash_base
defaulting to HEAD instead of using HEAD literaly.
The correct solution would be to make "html" page (i.e. "blob" not
"blob_plain" view) also for binary files. <img> element for image/*
mimetype, perhaps <embed> or <object>, or just plain link for other
binary (not text/* or some application/*) types
I was AFK for few days.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2006-09-29 20:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 19:47 [PATCH] gitweb: tree view: hash_base and hash are now context sensitive Luben Tuikov
2006-09-26 20:34 ` Jakub Narebski
2006-09-26 21:17 ` Luben Tuikov
2006-09-27 6:48 ` Junio C Hamano
2006-09-27 22:53 ` Luben Tuikov
2006-09-28 18:52 ` Luben Tuikov
2006-09-29 6:06 ` Junio C Hamano
2006-09-29 16:16 ` Luben Tuikov
2006-09-29 20:35 ` Jakub Narebski [this message]
2006-09-29 23:30 ` Luben Tuikov
2006-10-01 22:27 ` Jakub Narebski
2006-10-02 19:51 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2006-09-29 16:57 Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609292235.27478.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).