From: Luben Tuikov <ltuikov@yahoo.com>
To: Jakub Narebski <jnareb@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Remove excessively redundant entries from git_difftree_body
Date: Mon, 2 Oct 2006 12:48:47 -0700 (PDT) [thread overview]
Message-ID: <20061002194847.285.qmail@web31811.mail.mud.yahoo.com> (raw)
In-Reply-To: <efp4d6$a7b$1@sea.gmane.org>
--- Jakub Narebski <jnareb@gmail.com> wrote:
> Junio C Hamano wrote:
>
> > Luben Tuikov <ltuikov@yahoo.com> writes:
> >
> >> 1) All entries on the left are blobs and clicking on them
> >> leads to blobs. No more diff or blob depending on what
> >> happened (modified or mode changed) to the file -- this goes
> >> to the right, in the "link" column.
> >>
> >> 2) Remove redundant "blob" from the link column on the right.
> >> This can now be had by clicking on the entry itself.
> >>
> >> This reduces and simplifies the code.
> >>
> >> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> >
> > We lost blobdiff from commitdiff page with this patch, which I
> > think it probably is a good change. We can say "when we display
> > a pathname you can click it to get the blob or tree".
>
> In my opinion it is a bad change. We now have "patch" inner-link
> to anchor in commitdiff view, but it's equivalent in commit view
> i.e. diff aka blobdiff vanished.
All which can be easily had.
Luben
prev parent reply other threads:[~2006-10-02 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 0:23 [PATCH] gitweb: Remove excessively redundant entries from git_difftree_body Luben Tuikov
2006-09-28 2:07 ` Junio C Hamano
2006-09-28 18:28 ` Luben Tuikov
2006-10-01 19:20 ` Jakub Narebski
2006-10-02 19:48 ` Luben Tuikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061002194847.285.qmail@web31811.mail.mud.yahoo.com \
--to=ltuikov@yahoo.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).