From: Martin Waitz <tali@admingilde.org>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: start to generate PATH_INFO URLs
Date: Tue, 3 Oct 2006 19:12:29 +0200 [thread overview]
Message-ID: <20061003171229.GN2871@admingilde.org> (raw)
In-Reply-To: <eftk98$2ii$2@sea.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
hoi :)
On Tue, Oct 03, 2006 at 02:16:05PM +0200, Jakub Narebski wrote:
> Martin Waitz wrote:
> > Instead of providing the project as a ?p= parameter it is simply appended
> > to the base URI.
>
> I have just modified href() to be able to use it for actions which don't
> need the ?p= parameter... and you didn't take into consideration the case
> when $params{'project'} is set, but undefined.
is this handled correctly in the second patch which got committed to
next?
--
Martin Waitz
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-10-03 17:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 22:16 [PATCH] gitweb: start to generate PATH_INFO URLs Martin Waitz
2006-09-29 22:30 ` Junio C Hamano
2006-09-30 18:14 ` Martin Waitz
2006-09-30 19:42 ` Junio C Hamano
2006-10-01 21:57 ` Martin Waitz
2006-10-03 12:18 ` Jakub Narebski
2006-10-03 17:39 ` Junio C Hamano
2006-10-03 17:50 ` Jakub Narebski
2006-10-03 20:16 ` Junio C Hamano
2006-10-03 20:28 ` Martin Waitz
2006-10-03 18:07 ` [PATCH] gitweb: warn if feature cannot be overridden Martin Waitz
2006-10-03 16:43 ` [PATCH] gitweb: start to generate PATH_INFO URLs Jakub Narebski
2006-10-03 18:08 ` [PATCH] gitweb: make PATHINFO URL generation conditional on input URL Martin Waitz
2006-10-06 15:30 ` [PATCH] gitweb: start to generate PATH_INFO URLs Petr Baudis
2006-10-07 8:40 ` Junio C Hamano
2006-10-03 12:16 ` Jakub Narebski
2006-10-03 17:12 ` Martin Waitz [this message]
2006-10-03 17:19 ` Jakub Narebski
2006-10-03 17:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061003171229.GN2871@admingilde.org \
--to=tali@admingilde.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).