From: Martin Waitz <tali@admingilde.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Jakub Narebski <jnareb@gmail.com>, git@vger.kernel.org
Subject: [PATCH] gitweb: warn if feature cannot be overridden.
Date: Tue, 3 Oct 2006 20:07:43 +0200 [thread overview]
Message-ID: <20061003180743.GO2871@admingilde.org> (raw)
In-Reply-To: <7vbqotpadg.fsf@assigned-by-dhcp.cox.net>
If the administrator configures pathinfo to be overrideable by the
local repository a warning is shown.
Signed-off-by: Martin Waitz <tali@admingilde.org>
---
gitweb/gitweb.perl | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 10e803a..0ff6f7c 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -116,6 +116,10 @@ sub gitweb_check_feature {
$feature{$name}{'override'},
@{$feature{$name}{'default'}});
if (!$override) { return @defaults; }
+ if (!defined $sub) {
+ warn "feature $name is not overrideable";
+ return @defaults;
+ }
return $sub->(@defaults);
}
--
1.4.2.3
--
Martin Waitz
next prev parent reply other threads:[~2006-10-03 18:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 22:16 [PATCH] gitweb: start to generate PATH_INFO URLs Martin Waitz
2006-09-29 22:30 ` Junio C Hamano
2006-09-30 18:14 ` Martin Waitz
2006-09-30 19:42 ` Junio C Hamano
2006-10-01 21:57 ` Martin Waitz
2006-10-03 12:18 ` Jakub Narebski
2006-10-03 17:39 ` Junio C Hamano
2006-10-03 17:50 ` Jakub Narebski
2006-10-03 20:16 ` Junio C Hamano
2006-10-03 20:28 ` Martin Waitz
2006-10-03 18:07 ` Martin Waitz [this message]
2006-10-03 16:43 ` Jakub Narebski
2006-10-03 18:08 ` [PATCH] gitweb: make PATHINFO URL generation conditional on input URL Martin Waitz
2006-10-06 15:30 ` [PATCH] gitweb: start to generate PATH_INFO URLs Petr Baudis
2006-10-07 8:40 ` Junio C Hamano
2006-10-03 12:16 ` Jakub Narebski
2006-10-03 17:12 ` Martin Waitz
2006-10-03 17:19 ` Jakub Narebski
2006-10-03 17:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061003180743.GO2871@admingilde.org \
--to=tali@admingilde.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).