git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/3] gitweb: blame: Mouse-over commit-8 shows author and date
@ 2006-10-04  7:13 Luben Tuikov
  0 siblings, 0 replies; only message in thread
From: Luben Tuikov @ 2006-10-04  7:13 UTC (permalink / raw)
  To: git

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
 gitweb/gitweb.perl |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 1908141687-p2.txt --]
[-- Type: text/inline; name="p2.txt", Size: 995 bytes --]

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 9518086..cba0840 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2496,11 +2496,9 @@ sub git_blame2 {
 <tr><th>Commit</th><th>Line</th><th>Data</th></tr>
 HTML
 	while (<$fd>) {
-		/^([0-9a-fA-F]{40}).*?(\d+)\)\s{1}(\s*.*)/;
-		my $full_rev = $1;
+		my ($full_rev, $author, $date, $lineno, $data) =
+			/^([0-9a-f]{40}).*?\s\((.*?)\s+([-\d]+ [:\d]+ [-+\d]+)\s+(\d+)\)\s(.*)/;
 		my $rev = substr($full_rev, 0, 8);
-		my $lineno = $2;
-		my $data = $3;
 		my $print_c8 = 0;
 
 		if (!defined $last_rev) {
@@ -2512,7 +2510,11 @@ HTML
 			$print_c8 = 1;
 		}
 		print "<tr class=\"$rev_color[$current_color]\">\n";
-		print "<td class=\"sha1\">";
+		print "<td class=\"sha1\"";
+		if ($print_c8 == 1) {
+			print " title=\"$author, $date\"";
+		}
+		print ">";
 		if ($print_c8 == 1) {
 			print $cgi->a({-href => href(action=>"commit", hash=>$full_rev, file_name=>$file_name)},
 				      esc_html($rev));
-- 
1.4.2.1.ga68d6


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2006-10-04  7:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-04  7:13 [PATCH 2/3] gitweb: blame: Mouse-over commit-8 shows author and date Luben Tuikov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).