From: Luben Tuikov <ltuikov@yahoo.com>
To: git@vger.kernel.org
Subject: [PATCH 2/2] gitweb: blame: All rows have title; print 8 SP when no leading commit-8
Date: Wed, 4 Oct 2006 18:02:15 -0700 (PDT) [thread overview]
Message-ID: <20061005010215.63402.qmail@web31811.mail.mud.yahoo.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
Print eight spaces when no leading commit is being printed.
I.e. on all rows of a commit-block, but the first. This fixes
alignment in the destination buffer when blame data lines
are cut and pasted.
Also, now all rows have title.
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
gitweb/gitweb.perl | 13 +++++--------
1 files changed, 5 insertions(+), 8 deletions(-)
[-- Attachment #2: 1908141687-p2.txt --]
[-- Type: text/plain, Size: 898 bytes --]
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 451bf5d..2949fa4 100644
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2510,15 +2510,12 @@ HTML
$print_c8 = 1;
}
print "<tr class=\"$rev_color[$current_color]\">";
- print "<td class=\"sha1\"";
- if ($print_c8 == 1) {
- print " title=\"$author, $date\"";
- }
- print ">";
- if ($print_c8 == 1) {
- print $cgi->a({-href => href(action=>"commit", hash=>$full_rev, file_name=>$file_name)},
- esc_html($rev));
+ print "<td class=\"sha1\" title=\"$author, $date\">";
+ if ($print_c8 == 0) {
+ $rev = " ";
}
+ print $cgi->a({-href => href(action=>"commit", hash=>$full_rev, file_name=>$file_name)},
+ esc_html($rev));
print "</td>";
print "<td class=\"linenr\"><a id=\"l$lineno\" href=\"#l$lineno\" class=\"linenr\">" .
esc_html($lineno) . "</a></td>";
--
1.4.2.3.g7d77
next reply other threads:[~2006-10-05 1:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 1:02 Luben Tuikov [this message]
2006-10-05 1:24 ` [PATCH 2/2] gitweb: blame: All rows have title; print 8 SP when no leading commit-8 Junio C Hamano
2006-10-05 1:29 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061005010215.63402.qmail@web31811.mail.mud.yahoo.com \
--to=ltuikov@yahoo.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox