From: Luben Tuikov <ltuikov@yahoo.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: make leftmost column of blame less cluttered.
Date: Wed, 4 Oct 2006 18:11:37 -0700 (PDT) [thread overview]
Message-ID: <20061005011137.20903.qmail@web31807.mail.mud.yahoo.com> (raw)
In-Reply-To: <7v1wpnk20p.fsf@assigned-by-dhcp.cox.net>
--- Junio C Hamano <junkio@cox.net> wrote:
> Luben Tuikov <ltuikov@yahoo.com> writes:
>
> > Yes, I completely understand the problem you're describing
> > here and have seen even more extreme examples of it.
>
> I agree with your conclusion. More than one commit-8 placed in
> a large group end up visually suggesting that they are
> separating the group into multiple pieces that have some
> meaning, which is not, because the contrast of zebra shading
> between groups is very subtle and is much weaker than commit-8
> "clickable handles".
>
> I am not suggesting to make the contrast of shading stronger;
> that would make things harder to read, and readability matters
> more on that page.
>
> Will revert mine from "next" (along with the mistakenly dropped
> executable bit) and replace with your patch 1 and 2.
Sounds great -- thanks!
Luben
next prev parent reply other threads:[~2006-10-05 1:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 9:19 [PATCH] gitweb: make leftmost column of blame less cluttered Junio C Hamano
2006-10-02 19:29 ` Luben Tuikov
2006-10-03 4:19 ` Junio C Hamano
2006-10-03 7:25 ` Junio C Hamano
2006-10-03 19:08 ` Luben Tuikov
2006-10-03 19:20 ` Martin Waitz
2006-10-03 19:45 ` Luben Tuikov
2006-10-04 2:26 ` Junio C Hamano
2006-10-04 2:48 ` Luben Tuikov
2006-10-04 3:07 ` Jakub Narebski
2006-10-04 8:12 ` Junio C Hamano
2006-10-04 15:59 ` Luben Tuikov
2006-10-05 1:03 ` Junio C Hamano
2006-10-05 1:11 ` Luben Tuikov [this message]
2006-10-03 19:01 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061005011137.20903.qmail@web31807.mail.mud.yahoo.com \
--to=ltuikov@yahoo.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).