* [PATCH] gitweb: Add snapshot to shortlog
@ 2006-09-28 23:50 Luben Tuikov
2006-10-03 9:07 ` Jakub Narebski
0 siblings, 1 reply; 3+ messages in thread
From: Luben Tuikov @ 2006-09-28 23:50 UTC (permalink / raw)
To: git
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
Add snapshot to each commit-row of shortlog.
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
gitweb/gitweb.perl | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
[-- Attachment #2: 4046732943-p4.txt --]
[-- Type: text/plain, Size: 672 bytes --]
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index a2f07cc..953a0ef 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2021,7 +2021,8 @@ sub git_shortlog_body {
print "</td>\n" .
"<td class=\"link\">" .
$cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") . " | " .
- $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree");
+ $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree") . " | " .
+ $cgi->a({-href => href(action=>"snapshot", hash=>$commit)}, "snapshot");
print "</td>\n" .
"</tr>\n";
}
--
1.4.2.1.g05f0f
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gitweb: Add snapshot to shortlog
2006-09-28 23:50 [PATCH] gitweb: Add snapshot to shortlog Luben Tuikov
@ 2006-10-03 9:07 ` Jakub Narebski
2006-10-06 13:57 ` [PATCH] Show snapshot link in shortlog only if have_snapsho Petr Baudis
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Narebski @ 2006-10-03 9:07 UTC (permalink / raw)
To: git
Luben Tuikov wrote:
> Add snapshot to each commit-row of shortlog.
You should add it conditionally, checking for gitweb_have_snapshot.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Show snapshot link in shortlog only if have_snapsho
2006-10-03 9:07 ` Jakub Narebski
@ 2006-10-06 13:57 ` Petr Baudis
0 siblings, 0 replies; 3+ messages in thread
From: Petr Baudis @ 2006-10-06 13:57 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
gitweb/gitweb.perl | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 5c7d95b..bcb41cc 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2098,8 +2098,10 @@ sub git_shortlog_body {
print "</td>\n" .
"<td class=\"link\">" .
$cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") . " | " .
- $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree") . " | " .
- $cgi->a({-href => href(action=>"snapshot", hash=>$commit)}, "snapshot");
+ $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree");
+ if (gitweb_have_snapshot()) {
+ print " | " . $cgi->a({-href => href(action=>"snapshot", hash=>$commit)}, "snapshot");
+ }
print "</td>\n" .
"</tr>\n";
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-06 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-28 23:50 [PATCH] gitweb: Add snapshot to shortlog Luben Tuikov
2006-10-03 9:07 ` Jakub Narebski
2006-10-06 13:57 ` [PATCH] Show snapshot link in shortlog only if have_snapsho Petr Baudis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).