From: Matthew Wilcox <matthew@wil.cx>
To: git@vger.kernel.org
Subject: Make git-send-email detect mbox-style patches more readily
Date: Fri, 6 Oct 2006 14:24:14 -0600 [thread overview]
Message-ID: <20061006202414.GR2563@parisc-linux.org> (raw)
Earlier today, I embarrassed myself by trying to construct a patch that
git-send-email would send, and I missed out the putting
>From garbage
line on the front, which led it to send the patches with a
Subject: From: Matthew Wilcox <matthew@wil.cx>
line. Bad.
This patch makes git-send-email detect an mbox-style file more readily,
and correctly handles the patches I constructed.
--- git-core-willy/git-send-email.perl 2006-07-24 23:45:08.000000000 -0400
+++ git-core-1.4.1.1/git-send-email.perl 2006-10-06 16:02:37.000000000 -0400
@@ -451,6 +451,7 @@
if (!$header_done) {
$found_mbox = 1, next if (/^From /);
chomp;
+ $found_mbox = 1 if (/^(From|Date|Cc|Subject):/);
if ($found_mbox) {
if (/^Subject:\s+(.*)$/) {
next reply other threads:[~2006-10-06 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 20:24 Matthew Wilcox [this message]
2006-10-07 10:09 ` Make git-send-email detect mbox-style patches more readily Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006202414.GR2563@parisc-linux.org \
--to=matthew@wil.cx \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).