From: Sean <seanlkml@sympatico.ca>
To: Sean <seanlkml@sympatico.ca>
Cc: takis@lumumba.uhasselt.be (Panagiotis Issaris), git@vger.kernel.org
Subject: [RFC PATCH] Add WEBDAV timeout to http-fetch.
Date: Fri, 6 Oct 2006 22:04:01 -0400 [thread overview]
Message-ID: <BAYC1-PASMTP11CF83A008B0B3BA5F6B15AE100@CEZ.ICE> (raw)
Message-ID: <20061006220401.a4485d67.seanlkml@sympatico.ca> (raw)
In-Reply-To: <BAYC1-PASMTP08A34A8FB0703E4D2ABAF9AE130@CEZ.ICE>
If a server is having problems delivering the Git repo over WEBDAV,
timeout after two minutes so that a regular http transfer can
be tried.
---
http-fetch.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Not sure if this is the correct fix, but it should improve the situation
for cloning and fetching from servers like Takis's. When connecting to
his server WEBDAV doesn't respond after the initial connection. Nothing
proceeds until the OS connection times out many minutes later.
This patch sets the CURL timeout to two minutes so that things proceed
sooner. Even with this patch it takes two extra minutes of "dead time"
to complete all operations; obivously this still sucks.
However, I don't know if the two minute timeout is long enough for
all cases with a server where WEBDAV is functioning properly.
Hopefully someone who knows more about Curl can comment and perhaps
offer another solution.
Maybe the real solution is just to figure out and fix whatever is
going on with the WEBDAV server and forget this patch.
Sean
diff --git a/http-fetch.c b/http-fetch.c
index bc74f30..046245a 100644
--- a/http-fetch.c
+++ b/http-fetch.c
@@ -861,6 +861,7 @@ static int remote_ls(struct alt_base *re
curl_easy_setopt(slot->curl, CURLOPT_UPLOAD, 1);
curl_easy_setopt(slot->curl, CURLOPT_CUSTOMREQUEST, DAV_PROPFIND);
curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, dav_headers);
+ curl_easy_setopt(slot->curl, CURLOPT_TIMEOUT, 120);
if (start_active_slot(slot)) {
run_active_slot(slot);
--
1.4.2.3.gabd697
next prev parent reply other threads:[~2006-10-07 2:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 21:26 Problem cloning packed-and-pruned http repository Panagiotis Issaris
2006-10-06 22:05 ` Panagiotis Issaris
[not found] ` <20061006194930.cf400ec4.seanlkml@sympatico.ca>
2006-10-06 23:49 ` Sean
[not found] ` <20061006220401.a4485d67.seanlkml@sympatico.ca>
2006-10-07 2:04 ` Sean [this message]
2006-10-07 10:15 ` [RFC PATCH] Add WEBDAV timeout to http-fetch Junio C Hamano
2006-10-07 11:27 ` Jakub Narebski
2006-10-07 17:32 ` Johannes Schindelin
2006-10-07 17:45 ` Petr Baudis
2006-10-07 22:30 ` Petr Baudis
2006-10-07 22:36 ` Johannes Schindelin
2006-10-08 4:52 ` Junio C Hamano
2006-10-08 12:03 ` Johannes Schindelin
[not found] ` <20061008091932.4d8e62d9.seanlkml@sympatico.ca>
2006-10-08 13:19 ` Sean
2006-10-08 19:56 ` Junio C Hamano
2006-10-11 12:13 ` Panagiotis Issaris
2006-10-11 14:00 ` Johannes Schindelin
2006-10-07 19:35 ` Panagiotis Issaris
2006-10-07 22:24 ` Junio C Hamano
2006-10-07 8:30 ` Panagiotis Issaris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAYC1-PASMTP11CF83A008B0B3BA5F6B15AE100@CEZ.ICE \
--to=seanlkml@sympatico.ca \
--cc=git@vger.kernel.org \
--cc=takis@lumumba.uhasselt.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).