From: Jakub Narebski <jnareb@gmail.com>
To: Petr Baudis <pasky@suse.cz>
Cc: Luben Tuikov <ltuikov@yahoo.com>, git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Do not print "log" and "shortlog" redundantly in commit view
Date: Sat, 7 Oct 2006 16:05:22 +0200 [thread overview]
Message-ID: <200610071605.23277.jnareb@gmail.com> (raw)
In-Reply-To: <20061007132457.GB20017@pasky.or.cz>
Petr Baudis wrote:
> Then it will be impossible to get snapshot of any subtree (apart of
> manually constructing the URL). Hmm, and it's a bug that we don't show
> the snapshot link when listing tree entry in tree listing, I thought
> we did in the past...?
>
> I think we should make it more clear what each of the bars concerns,
> perhaps doing some more significant redesign:
>
> [summary] is redundant, you have this big project name link in the top
> left corner. All the other navbar options concern commit, so why not
> merge it with the awkward commit box below the navbars?
>
> All the "views bar" options concern the currently selected object, so
> why not merge it with the object "descriptor", that is the path?
>
> Patches will follow up.
I think that "summary" has it's place rather in the bottom navigation
bar, in the "views bar", because it is related to current object not
current commit (the "tree" entry in top navigation bar, "actions bar",
is somewhat misleading because it actually is the tree of the commit,
not any tree). But the refactoring of "views" navigation bar is a good
idea. For tree it would be
tree | _history_ | _blame_ | _snapshot_
(when there would be tree_blame back - there was short experiment, patch
on git list; snapshot of course only when enabled).
I'd leave "summary" view, because the uther, especially with custome
$home_link_str might be not obvous that it leads to summary view.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2006-10-07 14:04 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 19:22 [PATCH] gitweb: Do not print "log" and "shortlog" redundantly in commit view Luben Tuikov
2006-10-06 7:44 ` Jakub Narebski
2006-10-06 16:35 ` Petr Baudis
2006-10-06 22:16 ` Luben Tuikov
2006-10-07 13:24 ` Petr Baudis
2006-10-07 14:05 ` Jakub Narebski [this message]
2006-10-07 14:17 ` Petr Baudis
2006-10-07 14:10 ` [PATCH 1/2] gitweb: Show snapshot links for tree entries in tree listing Petr Baudis
2006-10-07 18:37 ` Luben Tuikov
2006-10-07 18:41 ` Petr Baudis
2006-10-07 18:52 ` Luben Tuikov
2006-10-07 19:15 ` Petr Baudis
2006-10-07 22:31 ` Junio C Hamano
2006-10-08 1:04 ` Luben Tuikov
2006-10-07 14:10 ` [PATCH 2/2] gitweb: Show trailing slash when listing tree entry " Petr Baudis
2006-10-07 18:44 ` Luben Tuikov
2006-10-07 19:06 ` Jakub Narebski
2006-10-07 19:12 ` Petr Baudis
2006-10-07 20:38 ` Jakub Narebski
2006-10-07 21:15 ` Petr Baudis
2006-10-07 21:27 ` Jakub Narebski
2006-10-09 20:55 ` Petr Baudis
2006-10-09 22:52 ` Junio C Hamano
2006-10-10 5:10 ` Junio C Hamano
2006-10-10 5:38 ` Luben Tuikov
2006-10-10 5:46 ` Junio C Hamano
2006-10-10 6:34 ` Luben Tuikov
2006-10-10 5:46 ` Jeff King
2006-10-10 6:41 ` Luben Tuikov
2006-10-10 6:58 ` Jeff King
2006-10-10 9:15 ` Jakub Narebski
2006-10-10 19:19 ` Luben Tuikov
2006-10-10 19:57 ` Junio C Hamano
2006-10-10 20:31 ` Jakub Narebski
2006-10-10 21:02 ` Luben Tuikov
2006-10-10 21:13 ` Jakub Narebski
2006-10-10 22:18 ` Luben Tuikov
2006-10-10 20:52 ` Luben Tuikov
2006-10-10 21:00 ` Jakub Narebski
2006-10-10 22:14 ` Luben Tuikov
2006-10-10 22:40 ` Jakub Narebski
2006-10-10 20:29 ` Jakub Narebski
2006-10-11 15:35 ` Andreas Ericsson
2006-10-10 6:21 ` Luben Tuikov
2006-10-10 7:05 ` Jeff King
2006-10-10 8:07 ` Andreas Ericsson
2006-10-10 13:14 ` Josef Weidendorfer
2006-10-10 18:23 ` Luben Tuikov
2006-10-10 18:52 ` Josef Weidendorfer
2006-10-10 18:50 ` Luben Tuikov
2006-10-10 8:28 ` Junio C Hamano
2006-10-07 21:31 ` A Large Angry SCM
2006-10-07 22:34 ` Junio C Hamano
2006-10-08 1:16 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610071605.23277.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=ltuikov@yahoo.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).