git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luben Tuikov <ltuikov@yahoo.com>
To: Jakub Narebski <jnareb@gmail.com>, Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: gitweb: using quotemeta
Date: Sat, 7 Oct 2006 10:41:21 -0700 (PDT)	[thread overview]
Message-ID: <20061007174121.44284.qmail@web31813.mail.mud.yahoo.com> (raw)
In-Reply-To: <200610071123.23654.jnareb@gmail.com>

--- Jakub Narebski <jnareb@gmail.com> wrote:
> Junio C Hamano wrote:
> > Jakub Narebski <jnareb@gmail.com> writes:
> > 
> >> I'd rather add (and use) separate subroutine for quoting/escaping
> >> values in HTTP headers, or to be more exact for the filename part
> >> of HTTP header "Content-Disposition:". This way if we decide to
> >> not replace all characters outside US-ASCII in suggested filename
> >> to save with '?', but only qoublequote '"' and linefeed '\n' characters,
> >> or even implement RFC 2047 to do the encoding (of course if browsers
> >> can read it), we could do this in one place. 
> > 
> > Sounds sane.  quote_filename?
> 
> Luben Tuikov used  to_qtext  in
>   "[PATCH] gitweb: Convert Content-Disposition filenames into qtext"
>   Msg-ID: <20061006191801.68649.qmail@web31815.mail.mud.yahoo.com>
>   http://permalink.gmane.org/gmane.comp.version-control.git/28437

I think that people familiar with the RFC will be able to quickly
recognize what this function does, after seeing "qtext" in the
name of the function.  After all, not only filenames can be qtext.

    Luben

  reply	other threads:[~2006-10-07 17:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-28 21:15 gitweb: using quotemeta Luben Tuikov
2006-09-28 23:18 ` Junio C Hamano
2006-09-28 23:27   ` Luben Tuikov
2006-10-02  0:28     ` Jakub Narebski
2006-10-02 20:12       ` Luben Tuikov
2006-10-02 20:50         ` Jakub Narebski
2006-10-03  6:30           ` Junio C Hamano
2006-10-06 12:38             ` Jakub Narebski
2006-10-07  5:08               ` Junio C Hamano
2006-10-07  9:23                 ` Jakub Narebski
2006-10-07 17:41                   ` Luben Tuikov [this message]
2006-10-11  9:48                     ` Jakub Narebski
2006-10-06 13:50         ` Petr Baudis
2006-10-06 18:21           ` Luben Tuikov
2006-10-06 18:45             ` Petr Baudis
  -- strict thread matches above, loose matches on Subject: below --
2006-10-06 18:24 Luben Tuikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061007174121.44284.qmail@web31813.mail.mud.yahoo.com \
    --to=ltuikov@yahoo.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).