git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luben Tuikov <ltuikov@yahoo.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Petr Baudis <pasky@suse.cz>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing
Date: Sat, 7 Oct 2006 18:16:34 -0700 (PDT)	[thread overview]
Message-ID: <20061008011634.844.qmail@web31814.mail.mud.yahoo.com> (raw)
In-Reply-To: <7vmz87pxg6.fsf@assigned-by-dhcp.cox.net>

--- Junio C Hamano <junkio@cox.net> wrote:
> Luben Tuikov <ltuikov@yahoo.com> writes:
> 
> > --- Petr Baudis <pasky@suse.cz> wrote:
> >> Signed-off-by: Petr Baudis <pasky@suse.cz>
> >> ---
> >
> > First, this is a Unixism, and would confuse other OS users.
> > Second, "/" is after all _not part of the name_ of the tree/directory,
> > but part of the filesystem's path separator, let's not export it
> > to users of other OS's.
> > Third, directories/trees are already clearly 
> >   1) underlined, and
> >   2) differently colored,
> > which makes it overly obvious what it what.
> 
> I was actually hoping that we can get rid of the differences you
> cited above.
> 
> Underlines make entries harder to read, and colouring is 
> distracting; some people do not see all colours and to them it
> may not distracting but then they need another way to notice the
> differences between tree/blob.

I know, I've seen your email on that and have your patch with the
icons applied at work.  But it is black and white and I'd rather
see some nice color and shading if we're going to change that.

I don't mind using nice warm color icons in the left-most column.

   Luben

      reply	other threads:[~2006-10-08  1:16 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-05 19:22 [PATCH] gitweb: Do not print "log" and "shortlog" redundantly in commit view Luben Tuikov
2006-10-06  7:44 ` Jakub Narebski
2006-10-06 16:35   ` Petr Baudis
2006-10-06 22:16   ` Luben Tuikov
2006-10-07 13:24     ` Petr Baudis
2006-10-07 14:05       ` Jakub Narebski
2006-10-07 14:17         ` Petr Baudis
2006-10-07 14:10       ` [PATCH 1/2] gitweb: Show snapshot links for tree entries in tree listing Petr Baudis
2006-10-07 18:37         ` Luben Tuikov
2006-10-07 18:41           ` Petr Baudis
2006-10-07 18:52             ` Luben Tuikov
2006-10-07 19:15               ` Petr Baudis
2006-10-07 22:31                 ` Junio C Hamano
2006-10-08  1:04                 ` Luben Tuikov
2006-10-07 14:10       ` [PATCH 2/2] gitweb: Show trailing slash when listing tree entry " Petr Baudis
2006-10-07 18:44         ` Luben Tuikov
2006-10-07 19:06           ` Jakub Narebski
2006-10-07 19:12             ` Petr Baudis
2006-10-07 20:38               ` Jakub Narebski
2006-10-07 21:15                 ` Petr Baudis
2006-10-07 21:27                   ` Jakub Narebski
2006-10-09 20:55               ` Petr Baudis
2006-10-09 22:52                 ` Junio C Hamano
2006-10-10  5:10                   ` Junio C Hamano
2006-10-10  5:38                     ` Luben Tuikov
2006-10-10  5:46                       ` Junio C Hamano
2006-10-10  6:34                         ` Luben Tuikov
2006-10-10  5:46                       ` Jeff King
2006-10-10  6:41                         ` Luben Tuikov
2006-10-10  6:58                           ` Jeff King
2006-10-10  9:15                       ` Jakub Narebski
2006-10-10 19:19                         ` Luben Tuikov
2006-10-10 19:57                           ` Junio C Hamano
2006-10-10 20:31                             ` Jakub Narebski
2006-10-10 21:02                               ` Luben Tuikov
2006-10-10 21:13                                 ` Jakub Narebski
2006-10-10 22:18                                   ` Luben Tuikov
2006-10-10 20:52                             ` Luben Tuikov
2006-10-10 21:00                               ` Jakub Narebski
2006-10-10 22:14                                 ` Luben Tuikov
2006-10-10 22:40                                   ` Jakub Narebski
2006-10-10 20:29                           ` Jakub Narebski
2006-10-11 15:35                           ` Andreas Ericsson
2006-10-10  6:21                 ` Luben Tuikov
2006-10-10  7:05                   ` Jeff King
2006-10-10  8:07                     ` Andreas Ericsson
2006-10-10 13:14                       ` Josef Weidendorfer
2006-10-10 18:23                         ` Luben Tuikov
2006-10-10 18:52                           ` Josef Weidendorfer
2006-10-10 18:50                         ` Luben Tuikov
2006-10-10  8:28                     ` Junio C Hamano
2006-10-07 21:31           ` A Large Angry SCM
2006-10-07 22:34           ` Junio C Hamano
2006-10-08  1:16             ` Luben Tuikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061008011634.844.qmail@web31814.mail.mud.yahoo.com \
    --to=ltuikov@yahoo.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).