From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Cleanup Git logo and Git logo target generation
Date: Mon, 9 Oct 2006 09:14:59 +0200 [thread overview]
Message-ID: <200610090914.59834.jnareb@gmail.com> (raw)
In-Reply-To: <7vac46gvg8.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
>> Junio C Hamano wrote:
>>
>>> Petr Baudis <pasky@suse.cz> writes:
>>>
>>>> Is there a problem with taking <200610061231.06017.jnareb@gmail.com>?
>>>>
>>>> I think it's currently not worth the complexity and breakage of
>>>> backwards compatibility to do the more elaborate form you proposed.
>>>
>>> I agree with that, except that the 72x27 dimension bit troubles
>>> me.
>>
>> First, that's the problem for the future. The 72x27 was there, I have not
>> introduced this.
>
> That's exactly my point. This is not a "placing blame" game.
>
> It just feels wrong to update only two things when we already
> know there are others that need fixing in a very similar way.
Well, I'd rather have it corrected, than wait for generalized version
which would allow to set dimensions and stuff... which is most probably
not needed.
Partial improvement is better than no improvement (especially as it
corrects 'href="'.esc_html($githelp_url).'"' bug).
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2006-10-09 7:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-19 21:27 [RFC][PATCH] gitweb: Make the Git logo link target to point to the homepage Petr Baudis
2006-09-23 12:57 ` Petr Baudis
2006-09-23 19:36 ` Junio C Hamano
2006-09-23 19:46 ` Petr Baudis
2006-10-05 20:47 ` Petr Baudis
2006-10-05 21:23 ` Junio C Hamano
2006-10-05 21:34 ` Junio C Hamano
2006-10-05 23:57 ` Petr Baudis
2006-09-23 19:54 ` Jakub Narebski
2006-09-23 20:46 ` Junio C Hamano
2006-10-06 10:31 ` [PATCH] gitweb: Cleanup Git logo and Git logo target generation Jakub Narebski
2006-10-07 8:36 ` Junio C Hamano
2006-10-07 9:58 ` Jakub Narebski
2006-10-07 14:14 ` Alan Chandler
2006-10-08 13:31 ` Jakub Narebski
2006-10-08 19:47 ` Junio C Hamano
2006-10-08 20:10 ` Petr Baudis
2006-10-08 20:33 ` Junio C Hamano
2006-10-08 20:54 ` Jakub Narebski
2006-10-09 0:54 ` Junio C Hamano
2006-10-09 7:14 ` Jakub Narebski [this message]
2006-10-09 9:00 ` Junio C Hamano
2006-10-09 9:26 ` Jakub Narebski
2006-10-09 20:36 ` Petr Baudis
2006-10-08 20:17 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610090914.59834.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).