From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Cleanup Git logo and Git logo target generation
Date: Mon, 9 Oct 2006 11:26:16 +0200 [thread overview]
Message-ID: <200610091126.17055.jnareb@gmail.com> (raw)
In-Reply-To: <7vvemtdfst.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> > Partial improvement is better than no improvement.
>
> Not necessarily. As the maintainer, I found that when we say
> "we will fix it later", later tend to never come, and one
> effective way to fight that tendency is to prod the contributors
> a bit harder, which worked reasonably well so far.
Well. Perhaps.
But first, it is also bugfix for esc_html on URL, and second I though
you rather have one feature per patch; this one has two - cleanup of
logo generation, and moving style to CSS. "Better" patch would have
three...
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2006-10-09 9:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-19 21:27 [RFC][PATCH] gitweb: Make the Git logo link target to point to the homepage Petr Baudis
2006-09-23 12:57 ` Petr Baudis
2006-09-23 19:36 ` Junio C Hamano
2006-09-23 19:46 ` Petr Baudis
2006-10-05 20:47 ` Petr Baudis
2006-10-05 21:23 ` Junio C Hamano
2006-10-05 21:34 ` Junio C Hamano
2006-10-05 23:57 ` Petr Baudis
2006-09-23 19:54 ` Jakub Narebski
2006-09-23 20:46 ` Junio C Hamano
2006-10-06 10:31 ` [PATCH] gitweb: Cleanup Git logo and Git logo target generation Jakub Narebski
2006-10-07 8:36 ` Junio C Hamano
2006-10-07 9:58 ` Jakub Narebski
2006-10-07 14:14 ` Alan Chandler
2006-10-08 13:31 ` Jakub Narebski
2006-10-08 19:47 ` Junio C Hamano
2006-10-08 20:10 ` Petr Baudis
2006-10-08 20:33 ` Junio C Hamano
2006-10-08 20:54 ` Jakub Narebski
2006-10-09 0:54 ` Junio C Hamano
2006-10-09 7:14 ` Jakub Narebski
2006-10-09 9:00 ` Junio C Hamano
2006-10-09 9:26 ` Jakub Narebski [this message]
2006-10-09 20:36 ` Petr Baudis
2006-10-08 20:17 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610091126.17055.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).