From: Jeff King <peff@peff.net>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: Junio C Hamano <junkio@cox.net>, Petr Baudis <pasky@suse.cz>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing
Date: Tue, 10 Oct 2006 02:58:49 -0400 [thread overview]
Message-ID: <20061010065849.GA2413@coredump.intra.peff.net> (raw)
In-Reply-To: <20061010064117.86409.qmail@web31813.mail.mud.yahoo.com>
On Mon, Oct 09, 2006 at 11:41:17PM -0700, Luben Tuikov wrote:
> Then let's universally underline absolutely _every_ link in gitweb
> which is clickable, regardless of where it appears, the font, typeset
> and size.
Instead, let's make a strawman argument!
Though I agree that it would be nicer for ALL links in gitweb to be
consistent, I think there is an argument to be made about look. However,
the specific example I mentioned is a single list in which some elements
are underlined and blue (which has been the classic user interface hint
for a link for a decade), and some aren't. Do you see why I think that
might be inconsistent?
> Unless you have "a priori" knowlege of "underline means clickable" there
Which was my argument in the first place (note that I was talking about
people with a high degree of computer exposure).
> is no chance of thinking that "not-underlined means not-clickable".
There is clearly a non-zero chance. Here's a relatively ridiculous
argument.
Look at the 'summary' page for a project. For each commit, there are
blue and underlined 'commitdiff', 'text', and 'snapshot' links. The
date, author, and message text have no such decoration. I click on the
underlined things and see that they are all links. I click on date and
author and see they are not links. The pattern of underlining links has
held for five out of six elements. Do you think it's unreasonable to
guess that the sixth element is not a link based on that pattern?
Look, I agree that not underlining everything might make the page look
nicer. And if we want to balance consistency against aesthetics, that's
fine. But please don't argue that there isn't an inconsistency.
-Peff
next prev parent reply other threads:[~2006-10-10 6:59 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 19:22 [PATCH] gitweb: Do not print "log" and "shortlog" redundantly in commit view Luben Tuikov
2006-10-06 7:44 ` Jakub Narebski
2006-10-06 16:35 ` Petr Baudis
2006-10-06 22:16 ` Luben Tuikov
2006-10-07 13:24 ` Petr Baudis
2006-10-07 14:05 ` Jakub Narebski
2006-10-07 14:17 ` Petr Baudis
2006-10-07 14:10 ` [PATCH 1/2] gitweb: Show snapshot links for tree entries in tree listing Petr Baudis
2006-10-07 18:37 ` Luben Tuikov
2006-10-07 18:41 ` Petr Baudis
2006-10-07 18:52 ` Luben Tuikov
2006-10-07 19:15 ` Petr Baudis
2006-10-07 22:31 ` Junio C Hamano
2006-10-08 1:04 ` Luben Tuikov
2006-10-07 14:10 ` [PATCH 2/2] gitweb: Show trailing slash when listing tree entry " Petr Baudis
2006-10-07 18:44 ` Luben Tuikov
2006-10-07 19:06 ` Jakub Narebski
2006-10-07 19:12 ` Petr Baudis
2006-10-07 20:38 ` Jakub Narebski
2006-10-07 21:15 ` Petr Baudis
2006-10-07 21:27 ` Jakub Narebski
2006-10-09 20:55 ` Petr Baudis
2006-10-09 22:52 ` Junio C Hamano
2006-10-10 5:10 ` Junio C Hamano
2006-10-10 5:38 ` Luben Tuikov
2006-10-10 5:46 ` Junio C Hamano
2006-10-10 6:34 ` Luben Tuikov
2006-10-10 5:46 ` Jeff King
2006-10-10 6:41 ` Luben Tuikov
2006-10-10 6:58 ` Jeff King [this message]
2006-10-10 9:15 ` Jakub Narebski
2006-10-10 19:19 ` Luben Tuikov
2006-10-10 19:57 ` Junio C Hamano
2006-10-10 20:31 ` Jakub Narebski
2006-10-10 21:02 ` Luben Tuikov
2006-10-10 21:13 ` Jakub Narebski
2006-10-10 22:18 ` Luben Tuikov
2006-10-10 20:52 ` Luben Tuikov
2006-10-10 21:00 ` Jakub Narebski
2006-10-10 22:14 ` Luben Tuikov
2006-10-10 22:40 ` Jakub Narebski
2006-10-10 20:29 ` Jakub Narebski
2006-10-11 15:35 ` Andreas Ericsson
2006-10-10 6:21 ` Luben Tuikov
2006-10-10 7:05 ` Jeff King
2006-10-10 8:07 ` Andreas Ericsson
2006-10-10 13:14 ` Josef Weidendorfer
2006-10-10 18:23 ` Luben Tuikov
2006-10-10 18:52 ` Josef Weidendorfer
2006-10-10 18:50 ` Luben Tuikov
2006-10-10 8:28 ` Junio C Hamano
2006-10-07 21:31 ` A Large Angry SCM
2006-10-07 22:34 ` Junio C Hamano
2006-10-08 1:16 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010065849.GA2413@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=ltuikov@yahoo.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).