From: Josef Weidendorfer <Josef.Weidendorfer@gmx.de>
To: Andreas Ericsson <ae@op5.se>
Cc: Jeff King <peff@peff.net>, Luben Tuikov <ltuikov@yahoo.com>,
Petr Baudis <pasky@suse.cz>, Jakub Narebski <jnareb@gmail.com>,
git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing
Date: Tue, 10 Oct 2006 15:14:17 +0200 [thread overview]
Message-ID: <200610101514.20705.Josef.Weidendorfer@gmx.de> (raw)
In-Reply-To: <452B54A5.4080901@op5.se>
On Tuesday 10 October 2006 10:07, Andreas Ericsson wrote:
> I like my links blue and underlined. Can't be arsed to mouse over things
> to figure out if they're clickable. If they're not blue and underlined,
> they're not, insofar as I'm concerned.
Same opinion here.
Better be functional than beautiful but confusing.
If Gitweb would be a desktop application, we would have context menues
for different actions on list items, but that is not really possible
with web pages (?), and would be unexpected.
Gitweb is a web interface. So lets use the conventions for web pages.
One solution is to repeat the actions everytime in every row of a list,
as we do now (and I think is fine; we could use icons instead). The other
standard solution is to have checkboxes at the front of every row, and
the actions as buttons, which means two mouse clicks (which IMHO is a
really bad UI).
And as we go with the first solution, we explicitly should state all
possible actions, and not provide an hidden action which is triggered
when clicking on the entry name. Currently, it is not very clear that
* we have a "blob" action at all,
* clicking on the entry name provides the blob action. Seems to me
like an arbitrary choice. Why not "raw" or "blame" instead?
Therefore, I am in favor of reintroducing the "blob" link,
which allows the entry names to stay as they are
now (and could get the hidden redundant action).
One thing I found confusing in this regard the first time:
Why do list rows show a recoloring with mouse over?
This somehow suggest that the whole row makes up some kind of
a button and is clickable (BTW, blame pages do not do this).
Can we get rid of this?
Josef
next prev parent reply other threads:[~2006-10-10 13:14 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 19:22 [PATCH] gitweb: Do not print "log" and "shortlog" redundantly in commit view Luben Tuikov
2006-10-06 7:44 ` Jakub Narebski
2006-10-06 16:35 ` Petr Baudis
2006-10-06 22:16 ` Luben Tuikov
2006-10-07 13:24 ` Petr Baudis
2006-10-07 14:05 ` Jakub Narebski
2006-10-07 14:17 ` Petr Baudis
2006-10-07 14:10 ` [PATCH 1/2] gitweb: Show snapshot links for tree entries in tree listing Petr Baudis
2006-10-07 18:37 ` Luben Tuikov
2006-10-07 18:41 ` Petr Baudis
2006-10-07 18:52 ` Luben Tuikov
2006-10-07 19:15 ` Petr Baudis
2006-10-07 22:31 ` Junio C Hamano
2006-10-08 1:04 ` Luben Tuikov
2006-10-07 14:10 ` [PATCH 2/2] gitweb: Show trailing slash when listing tree entry " Petr Baudis
2006-10-07 18:44 ` Luben Tuikov
2006-10-07 19:06 ` Jakub Narebski
2006-10-07 19:12 ` Petr Baudis
2006-10-07 20:38 ` Jakub Narebski
2006-10-07 21:15 ` Petr Baudis
2006-10-07 21:27 ` Jakub Narebski
2006-10-09 20:55 ` Petr Baudis
2006-10-09 22:52 ` Junio C Hamano
2006-10-10 5:10 ` Junio C Hamano
2006-10-10 5:38 ` Luben Tuikov
2006-10-10 5:46 ` Junio C Hamano
2006-10-10 6:34 ` Luben Tuikov
2006-10-10 5:46 ` Jeff King
2006-10-10 6:41 ` Luben Tuikov
2006-10-10 6:58 ` Jeff King
2006-10-10 9:15 ` Jakub Narebski
2006-10-10 19:19 ` Luben Tuikov
2006-10-10 19:57 ` Junio C Hamano
2006-10-10 20:31 ` Jakub Narebski
2006-10-10 21:02 ` Luben Tuikov
2006-10-10 21:13 ` Jakub Narebski
2006-10-10 22:18 ` Luben Tuikov
2006-10-10 20:52 ` Luben Tuikov
2006-10-10 21:00 ` Jakub Narebski
2006-10-10 22:14 ` Luben Tuikov
2006-10-10 22:40 ` Jakub Narebski
2006-10-10 20:29 ` Jakub Narebski
2006-10-11 15:35 ` Andreas Ericsson
2006-10-10 6:21 ` Luben Tuikov
2006-10-10 7:05 ` Jeff King
2006-10-10 8:07 ` Andreas Ericsson
2006-10-10 13:14 ` Josef Weidendorfer [this message]
2006-10-10 18:23 ` Luben Tuikov
2006-10-10 18:52 ` Josef Weidendorfer
2006-10-10 18:50 ` Luben Tuikov
2006-10-10 8:28 ` Junio C Hamano
2006-10-07 21:31 ` A Large Angry SCM
2006-10-07 22:34 ` Junio C Hamano
2006-10-08 1:16 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610101514.20705.Josef.Weidendorfer@gmx.de \
--to=josef.weidendorfer@gmx.de \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=junkio@cox.net \
--cc=ltuikov@yahoo.com \
--cc=pasky@suse.cz \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).