* paginate git-diff by default? @ 2006-10-10 18:13 Martin Waitz 2006-10-10 18:15 ` Shawn Pearce 2006-10-10 19:06 ` paginate git-diff by default? Johannes Schindelin 0 siblings, 2 replies; 5+ messages in thread From: Martin Waitz @ 2006-10-10 18:13 UTC (permalink / raw) To: git [-- Attachment #1: Type: text/plain, Size: 233 bytes --] hoi :) I always find myself typing "git -p diff". Should we paginate git-diff output by default? I was sure this was discussed before but I could not immediately find it, so I'm simply asking again ;-). -- Martin Waitz [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: paginate git-diff by default? 2006-10-10 18:13 paginate git-diff by default? Martin Waitz @ 2006-10-10 18:15 ` Shawn Pearce 2006-10-10 19:16 ` [PATCH] paginate git-diff by default Martin Waitz 2006-10-10 19:06 ` paginate git-diff by default? Johannes Schindelin 1 sibling, 1 reply; 5+ messages in thread From: Shawn Pearce @ 2006-10-10 18:15 UTC (permalink / raw) To: Martin Waitz; +Cc: git Martin Waitz <tali@admingilde.org> wrote: > hoi :) > > I always find myself typing "git -p diff". > Should we paginate git-diff output by default? > > I was sure this was discussed before but I could not immediately > find it, so I'm simply asking again ;-). I agree. I'm very used to git log automatically running my $PAGER; I'm always surprised that git diff doesn't do the same when attached to my tty. -- Shawn. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] paginate git-diff by default 2006-10-10 18:15 ` Shawn Pearce @ 2006-10-10 19:16 ` Martin Waitz 2006-10-11 0:57 ` Junio C Hamano 0 siblings, 1 reply; 5+ messages in thread From: Martin Waitz @ 2006-10-10 19:16 UTC (permalink / raw) To: Shawn Pearce; +Cc: git On Tue, Oct 10, 2006 at 02:15:58PM -0400, Shawn Pearce wrote: > Martin Waitz <tali@admingilde.org> wrote: > > I always find myself typing "git -p diff". > > Should we paginate git-diff output by default? > > I agree. I'm very used to git log automatically running my $PAGER; > I'm always surprised that git diff doesn't do the same when attached > to my tty. so here is the overly complex implementation: --- diff --git a/git.c b/git.c index 03acb25..3408e81 100644 --- a/git.c +++ b/git.c @@ -226,7 +226,7 @@ static void handle_internal_command(int { "check-ref-format", cmd_check_ref_format }, { "commit-tree", cmd_commit_tree, RUN_SETUP }, { "count-objects", cmd_count_objects, RUN_SETUP }, - { "diff", cmd_diff, RUN_SETUP }, + { "diff", cmd_diff, RUN_SETUP | USE_PAGER }, { "diff-files", cmd_diff_files, RUN_SETUP }, { "diff-index", cmd_diff_index, RUN_SETUP }, { "diff-stages", cmd_diff_stages, RUN_SETUP }, -- Martin Waitz ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] paginate git-diff by default 2006-10-10 19:16 ` [PATCH] paginate git-diff by default Martin Waitz @ 2006-10-11 0:57 ` Junio C Hamano 0 siblings, 0 replies; 5+ messages in thread From: Junio C Hamano @ 2006-10-11 0:57 UTC (permalink / raw) To: Martin Waitz; +Cc: git Martin Waitz <tali@admingilde.org> writes: > On Tue, Oct 10, 2006 at 02:15:58PM -0400, Shawn Pearce wrote: >> Martin Waitz <tali@admingilde.org> wrote: >> > I always find myself typing "git -p diff". >> > Should we paginate git-diff output by default? >> >> I agree. I'm very used to git log automatically running my $PAGER; >> I'm always surprised that git diff doesn't do the same when attached >> to my tty. Hmm. So close to 1.4.3... Will take it. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: paginate git-diff by default? 2006-10-10 18:13 paginate git-diff by default? Martin Waitz 2006-10-10 18:15 ` Shawn Pearce @ 2006-10-10 19:06 ` Johannes Schindelin 1 sibling, 0 replies; 5+ messages in thread From: Johannes Schindelin @ 2006-10-10 19:06 UTC (permalink / raw) To: Martin Waitz; +Cc: git Hi, On Tue, 10 Oct 2006, Martin Waitz wrote: > I always find myself typing "git -p diff". I don't. Because I have an alias "pd" for that on all of my machines. ;') Ciao, Dscho ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-10-11 0:58 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-10-10 18:13 paginate git-diff by default? Martin Waitz 2006-10-10 18:15 ` Shawn Pearce 2006-10-10 19:16 ` [PATCH] paginate git-diff by default Martin Waitz 2006-10-11 0:57 ` Junio C Hamano 2006-10-10 19:06 ` paginate git-diff by default? Johannes Schindelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).