From: Jakub Narebski <jnareb@gmail.com>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing
Date: Wed, 11 Oct 2006 00:40:20 +0200 [thread overview]
Message-ID: <200610110040.21235.jnareb@gmail.com> (raw)
In-Reply-To: <20061010221458.85789.qmail@web31804.mail.mud.yahoo.com>
Dnia środa 11. października 2006 00:14, Luben Tuikov napisał:
> --- Jakub Narebski <jnareb@gmail.com> wrote:
> > Luben Tuikov wrote:
> > > P.S. Notice how there is a "snapshot" link on each line of
> > > shortlog, but there is no "snapshot" link in the nav bar
> > > of a=commit. The "snapshot" link is next to "tree" down
> > > in the commit data. There is also a "tree" link which is also
> > > in the navbar, but "shortlog" is missing.
> >
> > The problem with snapshot is that we can have snapshot of a commit
> > (and all links in the top part of navigation bar till now deals with
> > current commit), and snapshot of a tree, which can be subdirectory
> > (and all links in the bottom part of navigation bar deals with
> > the views/presentations of a current object).
>
> Oh, yes, that's exactly what we need: two links of the same name
> ("snapshot") in the top row of navbar and in the bottom row of navbar.
I'm mentioning the problem, that "snapshot" has two meaning for a tree.
I personally think that we should have commit snapshot links (with
commit sha in the extended tar header if we use tgz snapshots) for
"heads", "tags" and "project list" views, and perhaps in the "commit"
and optionally "commitdiff" view; perhaps but not necessary for each
commit-list view like log, shortlog, search, history. But the snapshot
link should be as a view of a (sub)directory only in the bottom part of
navigation bar.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2006-10-10 22:42 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 19:22 [PATCH] gitweb: Do not print "log" and "shortlog" redundantly in commit view Luben Tuikov
2006-10-06 7:44 ` Jakub Narebski
2006-10-06 16:35 ` Petr Baudis
2006-10-06 22:16 ` Luben Tuikov
2006-10-07 13:24 ` Petr Baudis
2006-10-07 14:05 ` Jakub Narebski
2006-10-07 14:17 ` Petr Baudis
2006-10-07 14:10 ` [PATCH 1/2] gitweb: Show snapshot links for tree entries in tree listing Petr Baudis
2006-10-07 18:37 ` Luben Tuikov
2006-10-07 18:41 ` Petr Baudis
2006-10-07 18:52 ` Luben Tuikov
2006-10-07 19:15 ` Petr Baudis
2006-10-07 22:31 ` Junio C Hamano
2006-10-08 1:04 ` Luben Tuikov
2006-10-07 14:10 ` [PATCH 2/2] gitweb: Show trailing slash when listing tree entry " Petr Baudis
2006-10-07 18:44 ` Luben Tuikov
2006-10-07 19:06 ` Jakub Narebski
2006-10-07 19:12 ` Petr Baudis
2006-10-07 20:38 ` Jakub Narebski
2006-10-07 21:15 ` Petr Baudis
2006-10-07 21:27 ` Jakub Narebski
2006-10-09 20:55 ` Petr Baudis
2006-10-09 22:52 ` Junio C Hamano
2006-10-10 5:10 ` Junio C Hamano
2006-10-10 5:38 ` Luben Tuikov
2006-10-10 5:46 ` Junio C Hamano
2006-10-10 6:34 ` Luben Tuikov
2006-10-10 5:46 ` Jeff King
2006-10-10 6:41 ` Luben Tuikov
2006-10-10 6:58 ` Jeff King
2006-10-10 9:15 ` Jakub Narebski
2006-10-10 19:19 ` Luben Tuikov
2006-10-10 19:57 ` Junio C Hamano
2006-10-10 20:31 ` Jakub Narebski
2006-10-10 21:02 ` Luben Tuikov
2006-10-10 21:13 ` Jakub Narebski
2006-10-10 22:18 ` Luben Tuikov
2006-10-10 20:52 ` Luben Tuikov
2006-10-10 21:00 ` Jakub Narebski
2006-10-10 22:14 ` Luben Tuikov
2006-10-10 22:40 ` Jakub Narebski [this message]
2006-10-10 20:29 ` Jakub Narebski
2006-10-11 15:35 ` Andreas Ericsson
2006-10-10 6:21 ` Luben Tuikov
2006-10-10 7:05 ` Jeff King
2006-10-10 8:07 ` Andreas Ericsson
2006-10-10 13:14 ` Josef Weidendorfer
2006-10-10 18:23 ` Luben Tuikov
2006-10-10 18:52 ` Josef Weidendorfer
2006-10-10 18:50 ` Luben Tuikov
2006-10-10 8:28 ` Junio C Hamano
2006-10-07 21:31 ` A Large Angry SCM
2006-10-07 22:34 ` Junio C Hamano
2006-10-08 1:16 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610110040.21235.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).