From: Jeff King <peff@peff.net>
To: Petr Baudis <pasky@suse.cz>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Do not automatically append " git" to custom site name
Date: Wed, 11 Oct 2006 18:06:21 -0400 [thread overview]
Message-ID: <20061011220621.GA4041@coredump.intra.peff.net> (raw)
In-Reply-To: <20061011202228.27279.97423.stgit@rover>
On Wed, Oct 11, 2006 at 10:22:28PM +0200, Petr Baudis wrote:
> +our $site_name = "++GITWEB_SITENAME++" || "$ENV{'SERVER_NAME'} Git" || "Untitled Git";
This will never show "Untitled" (instead it shows " Git") and will cause
a perl warning if $ENV{SERVER_NAME} is not defined and warnings are
enabled (which tye are in gitweb).
I think this is what you want:
our $site_name = "++GITWEB_SITENAME++" ||
($ENV{SERVER_NAME} || "Untitled") . " Git";
-Peff
next prev parent reply other threads:[~2006-10-11 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 20:22 [PATCH] gitweb: Do not automatically append " git" to custom site name Petr Baudis
2006-10-11 20:31 ` Jakub Narebski
2006-10-11 22:06 ` Jeff King [this message]
2006-10-24 3:18 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061011220621.GA4041@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).