git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Nicolas Stroppa <nstroppa@computing.dcu.ie>
Cc: git@vger.kernel.org
Subject: Re: git-svnimport and tags
Date: Fri, 13 Oct 2006 22:15:37 +0200	[thread overview]
Message-ID: <20061013201537.GV20017@pasky.or.cz> (raw)
In-Reply-To: <452FA667.1060003@computing.dcu.ie>

  Hello,

Dear diary, on Fri, Oct 13, 2006 at 04:44:55PM CEST, I got a letter
where Nicolas Stroppa <nstroppa@computing.dcu.ie> said that...
> A small report. (I am using cogito-0.18 and git 1.4.2.3.)
> I have imported an SVN project using git-svnimport.
> This project has several tags. Here is what I get with one the tags.
> 
> tricatel $ git-cat-file tag `cat .git/refs/tags/alanis-0.9.4`
> object [...]
> type commit
> tag alanis-0.9.4
> tagger nico <nico>
> 
> 
> If I do the same thing on a git repository created from scratch, I get:
> 
> tricatel $ git-cat-file tag `cat .git/refs/tags/alanis-0.9.4`
> object [...]
> type commit
> tag alanis-0.9.4
> tagger nico <nico@[...]> 1160736694 +0100
> 
> The date information is missing in the first case, which confuses
> cg-tag-show:
> tricatel $ cg-tag-show alanis-0.9.4
> [...]
> cg-Xlib: line 215: nico <n (nic * 3600 + co> * 60):
> syntax error in expression (error token is "(nic * 3600 + co> * 60)")
> 
> I don't know if cg-tag-show should be more robust or if the date
> information should be in the tag.

  I think git-svnimport is broken here, the tagger line is clearly
defined that it must contain the time specification. And git-mktag is
broken as well since the verification of that line is a TODO so we let
the user put any garbage there.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)

      reply	other threads:[~2006-10-13 20:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-13 14:44 git-svnimport and tags Nicolas Stroppa
2006-10-13 20:15 ` Petr Baudis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061013201537.GV20017@pasky.or.cz \
    --to=pasky@suse.cz \
    --cc=git@vger.kernel.org \
    --cc=nstroppa@computing.dcu.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).