git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre HABOUZIT <madcoder@debian.org>
To: Eric Wong <normalperson@yhbt.net>, 392702@bugs.debian.org
Cc: git@vger.kernel.org
Subject: [PATCH] Re: git-svn: fix commits over svn+ssh://
Date: Sat, 14 Oct 2006 16:57:51 +0200	[thread overview]
Message-ID: <20061014145751.GA8840@hades.madism.org> (raw)
In-Reply-To: <11608165571212-git-send-email-normalperson@yhbt.net>

[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]

  I confirm that fixes it indeed.

On Sat, Oct 14, 2006 at 02:02:37AM -0700, Eric Wong wrote:
> Once a get_commit_editor has been called from an SVN session, RA
> layer operations are not allowed (well, unless you're using
> file:// or http(s)://).  So we'll pass an alternate SVN::Ra
> object to our editor object for running 'check-path'.
> 
> This should fix commits over svnserve (svn:// without ssh, too).
> 
> Closes Debian bug #392702, thanks to Pierre Habouzit for
> reporting the bug.
> 
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
>  git-svn.perl |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index a128d90..0f968c8 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -536,7 +536,7 @@ sub commit_lib {
>  			$SVN = libsvn_connect($repo);
>  			my $ed = SVN::Git::Editor->new(
>  					{	r => $r_last,
> -						ra => $SVN,
> +						ra => $SVN_LOG,
>  						c => $c,
>  						svn_path => $SVN_PATH
>  					},
> @@ -832,7 +832,7 @@ sub commit_diff {
>  	$SVN ||= libsvn_connect($repo);
>  	my @lock = $SVN::Core::VERSION ge '1.2.0' ? (undef, 0) : ();
>  	my $ed = SVN::Git::Editor->new({	r => $SVN->get_latest_revnum,
> -						ra => $SVN, c => $tb,
> +						ra => $SVN_LOG, c => $tb,
>  						svn_path => $SVN_PATH
>  					},
>  				$SVN->get_commit_editor($_message,
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2006-10-14 14:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-14  9:02 [PATCH] git-svn: fix commits over svn+ssh:// Eric Wong
2006-10-14 14:57 ` Pierre HABOUZIT [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061014145751.GA8840@hades.madism.org \
    --to=madcoder@debian.org \
    --cc=392702@bugs.debian.org \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).