* [PATCH] Fix tracing when GIT_TRACE is set to an empty string.
@ 2006-10-14 14:05 Christian Couder
2006-10-14 18:11 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Christian Couder @ 2006-10-14 14:05 UTC (permalink / raw)
To: Junio Hamano; +Cc: git
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
trace.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/trace.c b/trace.c
index f9efc91..495e5ed 100644
--- a/trace.c
+++ b/trace.c
@@ -55,7 +55,8 @@ static int get_trace_fd(int *need_close)
{
char *trace = getenv("GIT_TRACE");
- if (!trace || !strcmp(trace, "0") || !strcasecmp(trace, "false"))
+ if (!trace || !strcmp(trace, "") ||
+ !strcmp(trace, "0") || !strcasecmp(trace, "false"))
return 0;
if (!strcmp(trace, "1") || !strcasecmp(trace, "true"))
return STDERR_FILENO;
--
1.4.3.rc2.gadba
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix tracing when GIT_TRACE is set to an empty string.
2006-10-14 14:05 [PATCH] Fix tracing when GIT_TRACE is set to an empty string Christian Couder
@ 2006-10-14 18:11 ` Junio C Hamano
2006-10-14 19:55 ` Christian Couder
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2006-10-14 18:11 UTC (permalink / raw)
To: Christian Couder; +Cc: git
Christian Couder <chriscool@tuxfamily.org> writes:
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> trace.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/trace.c b/trace.c
> index f9efc91..495e5ed 100644
> --- a/trace.c
> +++ b/trace.c
> @@ -55,7 +55,8 @@ static int get_trace_fd(int *need_close)
> {
> char *trace = getenv("GIT_TRACE");
>
> - if (!trace || !strcmp(trace, "0") || !strcasecmp(trace, "false"))
> + if (!trace || !strcmp(trace, "") ||
> + !strcmp(trace, "0") || !strcasecmp(trace, "false"))
> return 0;
> if (!strcmp(trace, "1") || !strcasecmp(trace, "true"))
> return STDERR_FILENO;
> --
> 1.4.3.rc2.gadba
This means that
GIT_TRACE= git-foo
and
unset GIT_TRACE ; git-foo
should behave the same way, right?
If so that sounds sensible.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix tracing when GIT_TRACE is set to an empty string.
2006-10-14 18:11 ` Junio C Hamano
@ 2006-10-14 19:55 ` Christian Couder
0 siblings, 0 replies; 3+ messages in thread
From: Christian Couder @ 2006-10-14 19:55 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Junio C Hamano wrote:
> Christian Couder <chriscool@tuxfamily.org> writes:
> > Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> > ---
> > trace.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/trace.c b/trace.c
> > index f9efc91..495e5ed 100644
> > --- a/trace.c
> > +++ b/trace.c
> > @@ -55,7 +55,8 @@ static int get_trace_fd(int *need_close)
> > {
> > char *trace = getenv("GIT_TRACE");
> >
> > - if (!trace || !strcmp(trace, "0") || !strcasecmp(trace, "false"))
> > + if (!trace || !strcmp(trace, "") ||
> > + !strcmp(trace, "0") || !strcasecmp(trace, "false"))
> > return 0;
> > if (!strcmp(trace, "1") || !strcasecmp(trace, "true"))
> > return STDERR_FILENO;
> > --
> > 1.4.3.rc2.gadba
>
> This means that
>
> GIT_TRACE= git-foo
> and
> unset GIT_TRACE ; git-foo
>
> should behave the same way, right?
Yes, that's the goal of this patch.
> If so that sounds sensible.
Thanks,
Christian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-14 19:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-14 14:05 [PATCH] Fix tracing when GIT_TRACE is set to an empty string Christian Couder
2006-10-14 18:11 ` Junio C Hamano
2006-10-14 19:55 ` Christian Couder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).