From: Jeff King <peff@peff.net>
To: Pierre Habouzit <madcoder@debian.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] be more vim-ish, and also syntax hilight Signed-off-by lines.
Date: Wed, 18 Oct 2006 02:59:40 -0400 [thread overview]
Message-ID: <20061018065940.GC3507@coredump.intra.peff.net> (raw)
In-Reply-To: <11611319762395-git-send-email-madcoder@debian.org>
On Wed, Oct 18, 2006 at 02:39:35AM +0200, Pierre Habouzit wrote:
> +if exists("b:current_syntax")
> + finish
> +endif
I think this is a good change (along with commenting), but please write
a more descriptive commit message than "be more vim-ish" (I wouldn't
mind seeing this and the highlighting change broken into two patches,
since they are functionally completely unrelated).
> +syn region gitSignedOff start=/^Signed-off-by:/ end=/$/ contains=gitAuthor,gitEmail
> +syn region gitAuthor contained start=/\s/ end=/$/
You mention gitEmail but never define it. Are people using other things
besides Signed-off-by? I think we might do better to simply write:
syn region gitCommentHeader start=/^[^ ]\+:/ end=/$/ contains=gitCommentValue
syn region gitCommentValue contained start=/\s/ end=/$/
Highlighting only the header is inconsistent with other highlighting
(e.g., all of "new file: foo" is highlighted), but it looks so ugly to
highlight the whole line, so I think this is fine.
-Peff
prev parent reply other threads:[~2006-10-18 6:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 0:31 [PATCH] be more vim-ish, and also syntax hilight Signed-off-by lines Pierre Habouzit
2006-10-17 0:31 ` [PATCH] nice ftplugin for vim, that shows the commited diff in a split'ed buffer Pierre Habouzit
2006-10-17 8:22 ` Peter Baumann
2006-10-17 10:38 ` Pierre Habouzit
2006-10-17 10:59 ` Peter Baumann
2006-10-17 11:04 ` Pierre Habouzit
2006-10-17 21:48 ` Christian MICHON
2006-10-17 22:04 ` Junio C Hamano
2006-10-18 1:57 ` Petr Baudis
2006-10-17 7:46 ` [PATCH] be more vim-ish, and also syntax hilight Signed-off-by lines Junio C Hamano
2006-10-18 0:38 ` contrib/vim patches, replace the previous set Pierre Habouzit
2006-10-18 0:39 ` Pierre Habouzit
2006-10-18 0:39 ` [PATCH] be more vim-ish, and also syntax hilight Signed-off-by lines Pierre Habouzit
2006-10-18 0:39 ` [PATCH] Nice ftplugin for vim, that shows the commited diff in a split'ed buffer Pierre Habouzit
2006-10-18 0:40 ` Pierre Habouzit
2006-10-18 0:47 ` Make the ftplugin right wrt gitdir Pierre Habouzit
2006-10-18 0:47 ` [PATCH] be more robust wrt the git-dir Pierre Habouzit
2006-10-18 7:02 ` Make the ftplugin right wrt gitdir Jeff King
2006-10-18 8:10 ` Pierre Habouzit
2006-10-18 9:02 ` Jeff King
2006-10-18 9:07 ` Pierre Habouzit
2006-10-18 9:46 ` Jeff King
2006-10-18 6:59 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061018065940.GC3507@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).