From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Parkins Subject: git-imap-send and "From " Date: Sat, 21 Oct 2006 17:51:17 +0100 Message-ID: <200610211751.21581.andyparkins@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2712745.WpOKToVMBM"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit X-From: git-owner@vger.kernel.org Sat Oct 21 18:55:47 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GbK8B-0005o6-HW for gcvg-git@gmane.org; Sat, 21 Oct 2006 18:55:32 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993137AbWJUQyY (ORCPT ); Sat, 21 Oct 2006 12:54:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2993156AbWJUQyG (ORCPT ); Sat, 21 Oct 2006 12:54:06 -0400 Received: from ug-out-1314.google.com ([66.249.92.169]:53226 "EHLO ug-out-1314.google.com") by vger.kernel.org with ESMTP id S2993147AbWJUQxw (ORCPT ); Sat, 21 Oct 2006 12:53:52 -0400 Received: by ug-out-1314.google.com with SMTP id o38so955790ugd for ; Sat, 21 Oct 2006 09:53:51 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:from:to:subject:date:user-agent:mime-version:content-type:content-transfer-encoding:message-id; b=oMMuG8VWpeMbn6HvUFkQn5VxcoA4AC+Tp2CriqTB0sIf3byUA6YSiSIdmD1taKvw2QK2eV/3MWiJQ/DKC+LGK9rNTaIBwCPFKhVb0kR4EwVz7vTtXa7eeZedazFDgESoqzfGz9pJBTImww/8vRcYCFsUtLZPHLg5797OuJZTqfI= Received: by 10.66.222.9 with SMTP id u9mr4067155ugg; Sat, 21 Oct 2006 09:53:51 -0700 (PDT) Received: from grissom.internal.parkins.org.uk ( [84.201.153.164]) by mx.google.com with ESMTP id q1sm1577942uge.2006.10.21.09.53.50; Sat, 21 Oct 2006 09:53:51 -0700 (PDT) To: git@vger.kernel.org User-Agent: KMail/1.9.5 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: --nextPart2712745.WpOKToVMBM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hello, I've been playing around with git; made some simple patches for git and=20 thought I would forward them to the mailing list. I did this using git-format-patch --stdout --signoff -M -B | git-imap-send With the following in .gitconfig and courier-imap as the IMAP server. [imap] Folder =3D "INBOX.Drafts" Tunnel =3D "ssh -q mailhost /usr/bin/imapd ./Maildir 2> /dev/null" This appeared to work as expected. A nicely formatted patch appeared in my= =20 drafts mailbox for checking and sending; which I did. However, those email= s=20 caused a few problems; like: "Can you please not send your emails to "unlisted recipients?" It breaks my mail filtering and your mails don't end up going to my "git" folder." As far as I knew, I hadn't done this. The email looked fine when I checked= it=20 in KMail. So, I went back and had a look at the raw source of the patch=20 email that I'd sent and found this: =46rom 0e3c0aefc3276bd271553d171ed9bcc52d85230e Mon Sep 17 00:00:00 2001 =46rom: Andy Parkins Date: Fri, 20 Oct 2006 15:24:40 +0100 Subject: [PATCH] Use email address only for looking up signing key in git-t= ag It's that first line that's the problem. It was generated by git-format-pa= tch=20 of course, however, I assume that it was intended to be stripped on the way= =20 to the IMAP server. So, * Courier's /usr/bin/imapd should have stripped it and didn't * git-imap-send shouldn't have sent it Can anyone help me out with which it should be? Or point me at the relevan= t=20 RFC? While I was poking around I found that git is hard coded with printf("From %s Mon Sep 17 00:00:00 2001\n", sha1); Was it intentional that the date be hard coded like that? Andy =2D-=20 Dr Andrew Parkins, M Eng (Hons), AMIEE andyparkins@gmail.com --nextPart2712745.WpOKToVMBM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBFOlAJwQJ9gE9xL20RAiTvAKCaJX6uiJKH0nbMfSZUamrQ4C3AdACglmL+ mH497bk5aQgPxXwj6K9PVcw= =CSFv -----END PGP SIGNATURE----- --nextPart2712745.WpOKToVMBM--