* [PATCH] gitweb: Restore object-named links in item lists
@ 2006-10-24 3:12 Petr Baudis
2006-10-24 3:36 ` Petr Baudis
0 siblings, 1 reply; 8+ messages in thread
From: Petr Baudis @ 2006-10-24 3:12 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
This restores the redundant links removed earlier. It supersedes my patch
to stick slashes to tree entries.
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
gitweb/gitweb.perl | 33 +++++++++++++++++++++++++++------
1 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 4a2025c..695c632 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1793,16 +1793,18 @@ sub git_print_tree_entry {
file_name=>"$basedir$t->{'name'}", %base_key),
-class => "list"}, esc_html($t->{'name'})) . "</td>\n";
print "<td class=\"link\">";
+ print $cgi->a({-href => href(action=>"blob", hash=>$t->{'hash'},
+ file_name=>"$basedir$t->{'name'}", %base_key)},
+ "blob");
if ($have_blame) {
- print $cgi->a({-href => href(action=>"blame", hash=>$t->{'hash'},
+ print " | " .
+ $cgi->a({-href => href(action=>"blame", hash=>$t->{'hash'},
file_name=>"$basedir$t->{'name'}", %base_key)},
"blame");
}
if (defined $hash_base) {
- if ($have_blame) {
- print " | ";
- }
- print $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
+ print " | " .
+ $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
hash=>$t->{'hash'}, file_name=>"$basedir$t->{'name'}")},
"history");
}
@@ -1819,11 +1821,20 @@ sub git_print_tree_entry {
esc_html($t->{'name'}));
print "</td>\n";
print "<td class=\"link\">";
+ print $cgi->a({-href => href(action=>"tree", hash=>$t->{'hash'},
+ file_name=>"$basedir$t->{'name'}", %base_key)},
+ "tree");
if (defined $hash_base) {
- print $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
+ print " | " .
+ $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
file_name=>"$basedir$t->{'name'}")},
"history");
}
+ if ($have_snapshot) {
+ print " | " .
+ $cgi->a({-href => href(action=>"snapshot", hash=>$t->{'hash'})},
+ "snapshot");
+ }
print "</td>\n";
}
}
@@ -1903,6 +1914,9 @@ sub git_difftree_body {
print $cgi->a({-href => "#patch$patchno"}, "patch");
print " | ";
}
+ print $cgi->a({-href => href(action=>"blob", hash=>$diff{'from_id'},
+ hash_base=>$parent, file_name=>$diff{'file'})},
+ "blob") . " | ";
print $cgi->a({-href => href(action=>"blame", hash_base=>$parent,
file_name=>$diff{'file'})},
"blame") . " | ";
@@ -1948,6 +1962,9 @@ sub git_difftree_body {
}
print " | ";
}
+ print $cgi->a({-href => href(action=>"blob", hash=>$diff{'to_id'},
+ hash_base=>$hash, file_name=>$diff{'file'})},
+ "blob") . " | ";
print $cgi->a({-href => href(action=>"blame", hash_base=>$hash,
file_name=>$diff{'file'})},
"blame") . " | ";
@@ -1988,6 +2005,9 @@ sub git_difftree_body {
}
print " | ";
}
+ print $cgi->a({-href => href(action=>"blob", hash=>$diff{'from_id'},
+ hash_base=>$parent, file_name=>$diff{'from_file'})},
+ "blob") . " | ";
print $cgi->a({-href => href(action=>"blame", hash_base=>$parent,
file_name=>$diff{'from_file'})},
"blame") . " | ";
@@ -2155,6 +2175,7 @@ sub git_shortlog_body {
href(action=>"commit", hash=>$commit), $ref);
print "</td>\n" .
"<td class=\"link\">" .
+ $cgi->a({-href => href(action=>"commit", hash=>$commit)}, "commit") . " | " .
$cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") . " | " .
$cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree");
if (gitweb_have_snapshot()) {
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] gitweb: Restore object-named links in item lists
2006-10-24 3:12 [PATCH] gitweb: Restore object-named links in item lists Petr Baudis
@ 2006-10-24 3:36 ` Petr Baudis
2006-10-24 8:38 ` Luben Tuikov
2006-10-24 8:51 ` Jakub Narebski
0 siblings, 2 replies; 8+ messages in thread
From: Petr Baudis @ 2006-10-24 3:36 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
This restores the redundant links removed earlier. It supersedes my patch
to stick slashes to tree entries.
Sorry about the previous version of the patch, an unrelated snapshot link
addition to tree entries slipped through (and it it didn't even compile);
I've dropped the idea of snapshot links in tree entries in the meantime
anyway.
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
gitweb/gitweb.perl | 28 ++++++++++++++++++++++------
1 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 4a2025c..661d1dd 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1793,16 +1793,18 @@ sub git_print_tree_entry {
file_name=>"$basedir$t->{'name'}", %base_key),
-class => "list"}, esc_html($t->{'name'})) . "</td>\n";
print "<td class=\"link\">";
+ print $cgi->a({-href => href(action=>"blob", hash=>$t->{'hash'},
+ file_name=>"$basedir$t->{'name'}", %base_key)},
+ "blob");
if ($have_blame) {
- print $cgi->a({-href => href(action=>"blame", hash=>$t->{'hash'},
+ print " | " .
+ $cgi->a({-href => href(action=>"blame", hash=>$t->{'hash'},
file_name=>"$basedir$t->{'name'}", %base_key)},
"blame");
}
if (defined $hash_base) {
- if ($have_blame) {
- print " | ";
- }
- print $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
+ print " | " .
+ $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
hash=>$t->{'hash'}, file_name=>"$basedir$t->{'name'}")},
"history");
}
@@ -1819,8 +1821,12 @@ sub git_print_tree_entry {
esc_html($t->{'name'}));
print "</td>\n";
print "<td class=\"link\">";
+ print $cgi->a({-href => href(action=>"tree", hash=>$t->{'hash'},
+ file_name=>"$basedir$t->{'name'}", %base_key)},
+ "tree");
if (defined $hash_base) {
- print $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
+ print " | " .
+ $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
file_name=>"$basedir$t->{'name'}")},
"history");
}
@@ -1903,6 +1909,9 @@ sub git_difftree_body {
print $cgi->a({-href => "#patch$patchno"}, "patch");
print " | ";
}
+ print $cgi->a({-href => href(action=>"blob", hash=>$diff{'from_id'},
+ hash_base=>$parent, file_name=>$diff{'file'})},
+ "blob") . " | ";
print $cgi->a({-href => href(action=>"blame", hash_base=>$parent,
file_name=>$diff{'file'})},
"blame") . " | ";
@@ -1948,6 +1957,9 @@ sub git_difftree_body {
}
print " | ";
}
+ print $cgi->a({-href => href(action=>"blob", hash=>$diff{'to_id'},
+ hash_base=>$hash, file_name=>$diff{'file'})},
+ "blob") . " | ";
print $cgi->a({-href => href(action=>"blame", hash_base=>$hash,
file_name=>$diff{'file'})},
"blame") . " | ";
@@ -1988,6 +2000,9 @@ sub git_difftree_body {
}
print " | ";
}
+ print $cgi->a({-href => href(action=>"blob", hash=>$diff{'from_id'},
+ hash_base=>$parent, file_name=>$diff{'from_file'})},
+ "blob") . " | ";
print $cgi->a({-href => href(action=>"blame", hash_base=>$parent,
file_name=>$diff{'from_file'})},
"blame") . " | ";
@@ -2155,6 +2170,7 @@ sub git_shortlog_body {
href(action=>"commit", hash=>$commit), $ref);
print "</td>\n" .
"<td class=\"link\">" .
+ $cgi->a({-href => href(action=>"commit", hash=>$commit)}, "commit") . " | " .
$cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") . " | " .
$cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree");
if (gitweb_have_snapshot()) {
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] gitweb: Restore object-named links in item lists
2006-10-24 3:36 ` Petr Baudis
@ 2006-10-24 8:38 ` Luben Tuikov
2006-10-24 8:51 ` Jakub Narebski
1 sibling, 0 replies; 8+ messages in thread
From: Luben Tuikov @ 2006-10-24 8:38 UTC (permalink / raw)
To: Petr Baudis, Junio C Hamano; +Cc: git
--- Petr Baudis <pasky@suse.cz> wrote:
> This restores the redundant links removed earlier. It supersedes my patch
> to stick slashes to tree entries.
>
> Sorry about the previous version of the patch, an unrelated snapshot link
> addition to tree entries slipped through (and it it didn't even compile);
> I've dropped the idea of snapshot links in tree entries in the meantime
> anyway.
>
> Signed-off-by: Petr Baudis <pasky@suse.cz>
> ---
http://marc.theaimsgroup.com/?t=116059799500003&r=1&w=2
Luben
>
> gitweb/gitweb.perl | 28 ++++++++++++++++++++++------
> 1 files changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 4a2025c..661d1dd 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1793,16 +1793,18 @@ sub git_print_tree_entry {
> file_name=>"$basedir$t->{'name'}", %base_key),
> -class => "list"}, esc_html($t->{'name'})) . "</td>\n";
> print "<td class=\"link\">";
> + print $cgi->a({-href => href(action=>"blob", hash=>$t->{'hash'},
> + file_name=>"$basedir$t->{'name'}", %base_key)},
> + "blob");
> if ($have_blame) {
> - print $cgi->a({-href => href(action=>"blame", hash=>$t->{'hash'},
> + print " | " .
> + $cgi->a({-href => href(action=>"blame", hash=>$t->{'hash'},
> file_name=>"$basedir$t->{'name'}", %base_key)},
> "blame");
> }
> if (defined $hash_base) {
> - if ($have_blame) {
> - print " | ";
> - }
> - print $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
> + print " | " .
> + $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
> hash=>$t->{'hash'}, file_name=>"$basedir$t->{'name'}")},
> "history");
> }
> @@ -1819,8 +1821,12 @@ sub git_print_tree_entry {
> esc_html($t->{'name'}));
> print "</td>\n";
> print "<td class=\"link\">";
> + print $cgi->a({-href => href(action=>"tree", hash=>$t->{'hash'},
> + file_name=>"$basedir$t->{'name'}", %base_key)},
> + "tree");
> if (defined $hash_base) {
> - print $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
> + print " | " .
> + $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
> file_name=>"$basedir$t->{'name'}")},
> "history");
> }
> @@ -1903,6 +1909,9 @@ sub git_difftree_body {
> print $cgi->a({-href => "#patch$patchno"}, "patch");
> print " | ";
> }
> + print $cgi->a({-href => href(action=>"blob", hash=>$diff{'from_id'},
> + hash_base=>$parent, file_name=>$diff{'file'})},
> + "blob") . " | ";
> print $cgi->a({-href => href(action=>"blame", hash_base=>$parent,
> file_name=>$diff{'file'})},
> "blame") . " | ";
> @@ -1948,6 +1957,9 @@ sub git_difftree_body {
> }
> print " | ";
> }
> + print $cgi->a({-href => href(action=>"blob", hash=>$diff{'to_id'},
> + hash_base=>$hash, file_name=>$diff{'file'})},
> + "blob") . " | ";
> print $cgi->a({-href => href(action=>"blame", hash_base=>$hash,
> file_name=>$diff{'file'})},
> "blame") . " | ";
> @@ -1988,6 +2000,9 @@ sub git_difftree_body {
> }
> print " | ";
> }
> + print $cgi->a({-href => href(action=>"blob", hash=>$diff{'from_id'},
> + hash_base=>$parent, file_name=>$diff{'from_file'})},
> + "blob") . " | ";
> print $cgi->a({-href => href(action=>"blame", hash_base=>$parent,
> file_name=>$diff{'from_file'})},
> "blame") . " | ";
> @@ -2155,6 +2170,7 @@ sub git_shortlog_body {
> href(action=>"commit", hash=>$commit), $ref);
> print "</td>\n" .
> "<td class=\"link\">" .
> + $cgi->a({-href => href(action=>"commit", hash=>$commit)}, "commit") . " | " .
> $cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") . " | " .
> $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree");
> if (gitweb_have_snapshot()) {
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] gitweb: Restore object-named links in item lists
2006-10-24 3:36 ` Petr Baudis
2006-10-24 8:38 ` Luben Tuikov
@ 2006-10-24 8:51 ` Jakub Narebski
1 sibling, 0 replies; 8+ messages in thread
From: Jakub Narebski @ 2006-10-24 8:51 UTC (permalink / raw)
To: git
Petr Baudis wrote:
> This restores the redundant links removed earlier. It supersedes my patch
> to stick slashes to tree entries.
I would put those "redundant links" in separate column (like for git_tags).
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] gitweb: Restore object-named links in item lists
@ 2006-10-11 20:18 Petr Baudis
2006-10-11 21:48 ` Junio C Hamano
2006-10-11 22:21 ` Luben Tuikov
0 siblings, 2 replies; 8+ messages in thread
From: Petr Baudis @ 2006-10-11 20:18 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
This restores the redundant links removed earlier. It supersedes my patch
to stick slashes to tree entries.
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
gitweb/gitweb.perl | 42 ++++++++++++++++++++++++++++--------------
1 files changed, 28 insertions(+), 14 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index a11fa38..d8298b9 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1785,18 +1785,20 @@ sub git_print_tree_entry {
file_name=>"$basedir$t->{'name'}", %base_key),
-class => "list"}, esc_html($t->{'name'})) . "</td>\n";
print "<td class=\"link\">";
+ print $cgi->a({-href => href(action=>"blob", hash=>$t->{'hash'},
+ file_name=>"$basedir$t->{'name'}", %base_key)},
+ "blob");
if ($have_blame) {
- print $cgi->a({-href => href(action=>"blame", hash=>$t->{'hash'},
+ print " | " .
+ $cgi->a({-href => href(action=>"blame", hash=>$t->{'hash'},
file_name=>"$basedir$t->{'name'}", %base_key)},
- "blame");
+ "blame");
}
if (defined $hash_base) {
- if ($have_blame) {
- print " | ";
- }
- print $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
+ print " | " .
+ $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
hash=>$t->{'hash'}, file_name=>"$basedir$t->{'name'}")},
- "history");
+ "history");
}
print " | " .
$cgi->a({-href => href(action=>"blob_plain", hash_base=>$hash_base,
@@ -1811,17 +1813,19 @@ sub git_print_tree_entry {
esc_html($t->{'name'}));
print "</td>\n";
print "<td class=\"link\">";
+ print $cgi->a({-href => href(action=>"tree", hash=>$t->{'hash'},
+ file_name=>"$basedir$t->{'name'}", %base_key)},
+ "tree");
if (defined $hash_base) {
- print $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
+ print " | " .
+ $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
file_name=>"$basedir$t->{'name'}")},
- "history");
- if ($have_snapshot) {
- print " | ";
- }
+ "history");
}
if ($have_snapshot) {
- print $cgi->a({-href => href(action=>"snapshot", hash=>$t->{'hash'})},
- "snapshot");
+ print " | " .
+ $cgi->a({-href => href(action=>"snapshot", hash=>$t->{'hash'})},
+ "snapshot");
}
print "</td>\n";
}
@@ -1902,6 +1906,9 @@ sub git_difftree_body {
print $cgi->a({-href => "#patch$patchno"}, "patch");
print " | ";
}
+ print $cgi->a({-href => href(action=>"blob", hash=>$diff{'from_id'},
+ hash_base=>$parent, file_name=>$diff{'file'})},
+ "blob") . " | ";
print $cgi->a({-href => href(action=>"blame", hash_base=>$parent,
file_name=>$diff{'file'})},
"blame") . " | ";
@@ -1947,6 +1954,9 @@ sub git_difftree_body {
}
print " | ";
}
+ print $cgi->a({-href => href(action=>"blob", hash=>$diff{'to_id'},
+ hash_base=>$hash, file_name=>$diff{'file'})},
+ "blob") . " | ";
print $cgi->a({-href => href(action=>"blame", hash_base=>$hash,
file_name=>$diff{'file'})},
"blame") . " | ";
@@ -1987,6 +1997,9 @@ sub git_difftree_body {
}
print " | ";
}
+ print $cgi->a({-href => href(action=>"blob", hash=>$diff{'from_id'},
+ hash_base=>$parent, file_name=>$diff{'from_file'})},
+ "blob") . " | ";
print $cgi->a({-href => href(action=>"blame", hash_base=>$parent,
file_name=>$diff{'from_file'})},
"blame") . " | ";
@@ -2154,6 +2167,7 @@ sub git_shortlog_body {
href(action=>"commit", hash=>$commit), $ref);
print "</td>\n" .
"<td class=\"link\">" .
+ $cgi->a({-href => href(action=>"commit", hash=>$commit)}, "commit") . " | " .
$cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") . " | " .
$cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree");
if (gitweb_have_snapshot()) {
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] gitweb: Restore object-named links in item lists
2006-10-11 20:18 Petr Baudis
@ 2006-10-11 21:48 ` Junio C Hamano
2006-10-11 22:21 ` Luben Tuikov
1 sibling, 0 replies; 8+ messages in thread
From: Junio C Hamano @ 2006-10-11 21:48 UTC (permalink / raw)
To: Petr Baudis; +Cc: git
I would love to take this but please defer it for now; the patch
does not apply to any of my topic branches (nor "next").
I'd like to stabilize "master" for v1.4.3 this week, and would
like to merge bunch of stuff that are already in "next" to
"master" after that. I'd prefer to come back to gitweb when the
dust settles.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gitweb: Restore object-named links in item lists
2006-10-11 20:18 Petr Baudis
2006-10-11 21:48 ` Junio C Hamano
@ 2006-10-11 22:21 ` Luben Tuikov
2006-10-11 22:46 ` Jakub Narebski
1 sibling, 1 reply; 8+ messages in thread
From: Luben Tuikov @ 2006-10-11 22:21 UTC (permalink / raw)
To: Petr Baudis, Junio C Hamano; +Cc: git
--- Petr Baudis <pasky@suse.cz> wrote:
> This restores the redundant links removed earlier. It supersedes my patch
> to stick slashes to tree entries.
I NACK this, but it depends on Junio.
BTW, if you so much like to bring this back,
why don't you _revert_ the commit which removed them,
_resolve_, _commit_ and then submit that commit.
The reason is that we know that the original works
and here you're rewriting (untested as opposed
to the original) code.
NACK, I don't see the need for this.
But if this does go in, can you please remove the
"hidden" links so that _less_ identical code is left
to be maintained. (I don't know anyone who's getting
paid to maintain gitweb, do you?)
Luben
>
> Signed-off-by: Petr Baudis <pasky@suse.cz>
> ---
>
> gitweb/gitweb.perl | 42 ++++++++++++++++++++++++++++--------------
> 1 files changed, 28 insertions(+), 14 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index a11fa38..d8298b9 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1785,18 +1785,20 @@ sub git_print_tree_entry {
> file_name=>"$basedir$t->{'name'}", %base_key),
> -class => "list"}, esc_html($t->{'name'})) . "</td>\n";
> print "<td class=\"link\">";
> + print $cgi->a({-href => href(action=>"blob", hash=>$t->{'hash'},
> + file_name=>"$basedir$t->{'name'}", %base_key)},
> + "blob");
> if ($have_blame) {
> - print $cgi->a({-href => href(action=>"blame", hash=>$t->{'hash'},
> + print " | " .
> + $cgi->a({-href => href(action=>"blame", hash=>$t->{'hash'},
> file_name=>"$basedir$t->{'name'}", %base_key)},
> - "blame");
> + "blame");
> }
> if (defined $hash_base) {
> - if ($have_blame) {
> - print " | ";
> - }
> - print $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
> + print " | " .
> + $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
> hash=>$t->{'hash'}, file_name=>"$basedir$t->{'name'}")},
> - "history");
> + "history");
> }
> print " | " .
> $cgi->a({-href => href(action=>"blob_plain", hash_base=>$hash_base,
> @@ -1811,17 +1813,19 @@ sub git_print_tree_entry {
> esc_html($t->{'name'}));
> print "</td>\n";
> print "<td class=\"link\">";
> + print $cgi->a({-href => href(action=>"tree", hash=>$t->{'hash'},
> + file_name=>"$basedir$t->{'name'}", %base_key)},
> + "tree");
> if (defined $hash_base) {
> - print $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
> + print " | " .
> + $cgi->a({-href => href(action=>"history", hash_base=>$hash_base,
> file_name=>"$basedir$t->{'name'}")},
> - "history");
> - if ($have_snapshot) {
> - print " | ";
> - }
> + "history");
> }
> if ($have_snapshot) {
> - print $cgi->a({-href => href(action=>"snapshot", hash=>$t->{'hash'})},
> - "snapshot");
> + print " | " .
> + $cgi->a({-href => href(action=>"snapshot", hash=>$t->{'hash'})},
> + "snapshot");
> }
> print "</td>\n";
> }
> @@ -1902,6 +1906,9 @@ sub git_difftree_body {
> print $cgi->a({-href => "#patch$patchno"}, "patch");
> print " | ";
> }
> + print $cgi->a({-href => href(action=>"blob", hash=>$diff{'from_id'},
> + hash_base=>$parent, file_name=>$diff{'file'})},
> + "blob") . " | ";
> print $cgi->a({-href => href(action=>"blame", hash_base=>$parent,
> file_name=>$diff{'file'})},
> "blame") . " | ";
> @@ -1947,6 +1954,9 @@ sub git_difftree_body {
> }
> print " | ";
> }
> + print $cgi->a({-href => href(action=>"blob", hash=>$diff{'to_id'},
> + hash_base=>$hash, file_name=>$diff{'file'})},
> + "blob") . " | ";
> print $cgi->a({-href => href(action=>"blame", hash_base=>$hash,
> file_name=>$diff{'file'})},
> "blame") . " | ";
> @@ -1987,6 +1997,9 @@ sub git_difftree_body {
> }
> print " | ";
> }
> + print $cgi->a({-href => href(action=>"blob", hash=>$diff{'from_id'},
> + hash_base=>$parent, file_name=>$diff{'from_file'})},
> + "blob") . " | ";
> print $cgi->a({-href => href(action=>"blame", hash_base=>$parent,
> file_name=>$diff{'from_file'})},
> "blame") . " | ";
> @@ -2154,6 +2167,7 @@ sub git_shortlog_body {
> href(action=>"commit", hash=>$commit), $ref);
> print "</td>\n" .
> "<td class=\"link\">" .
> + $cgi->a({-href => href(action=>"commit", hash=>$commit)}, "commit") . " | " .
> $cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") . " | " .
> $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree");
> if (gitweb_have_snapshot()) {
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] gitweb: Restore object-named links in item lists
2006-10-11 22:21 ` Luben Tuikov
@ 2006-10-11 22:46 ` Jakub Narebski
0 siblings, 0 replies; 8+ messages in thread
From: Jakub Narebski @ 2006-10-11 22:46 UTC (permalink / raw)
To: git
Luben Tuikov wrote:
> But if this does go in, can you please remove the
> "hidden" links so that _less_ identical code is left
> to be maintained. (I don't know anyone who's getting
> paid to maintain gitweb, do you?)
We could instead save common part of links in the temporary
variable. I quite like those "hidden links", they make area where
we can click larger.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2006-10-24 8:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-24 3:12 [PATCH] gitweb: Restore object-named links in item lists Petr Baudis
2006-10-24 3:36 ` Petr Baudis
2006-10-24 8:38 ` Luben Tuikov
2006-10-24 8:51 ` Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2006-10-11 20:18 Petr Baudis
2006-10-11 21:48 ` Junio C Hamano
2006-10-11 22:21 ` Luben Tuikov
2006-10-11 22:46 ` Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).