From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/1 (amend)] gitweb: Use fixed string for "next" link in commitdiff view
Date: Tue, 24 Oct 2006 11:28:34 +0200 [thread overview]
Message-ID: <200610241128.34532.jnareb@gmail.com> (raw)
In-Reply-To: <7vfydehy2q.fsf@assigned-by-dhcp.cox.net>
Dnia wtorek 24. października 2006 11:17, Junio C Hamano napisał:
> Jakub Narebski <jnareb@gmail.com> writes:
>
>> Use fixed string instead of shortened SHA1 identifier of commit
>> as a name for "mext" link in commitdiff view.
>>
>> While at it make sure that we don't mistake option for a second
>> commit.
>>
>> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
>> ---
>
> Q1. (amend) to fix what?
Petr "Pasky" Baudis wrote:
>> } else {
>> # merge commit
>> $formats_nav .=
>> - ' (merge: ' .
>> + ' (' .
[...]
> For people not used to git, it would be more informative to keep the
> 'merge' text there.
It also fixes detection if it is diff of two specified commits. Although
$hash_parent is set to '--root' for rootloess commit later, we could
have it set by hand. This is also preparation for later using '--cc'
(although we wouldn't generate such URL, I don't think).
> Q2. "mext"?
Oops.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2006-10-24 9:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-22 22:37 [PATCH] gitweb: Add "next" link to commitdiff view Jakub Narebski
2006-10-22 22:43 ` Jakub Narebski
2006-10-22 23:16 ` Junio C Hamano
2006-10-22 23:41 ` Jakub Narebski
2006-10-23 22:08 ` [PATCH 2/1] gitweb: Use fixed string for "next" link in " Jakub Narebski
2006-10-23 23:21 ` Petr Baudis
2006-10-24 9:04 ` [PATCH 2/1 (amend)] " Jakub Narebski
2006-10-24 9:17 ` Junio C Hamano
2006-10-24 9:28 ` Jakub Narebski [this message]
2006-10-24 11:49 ` [PATCH 2/1] " Petr Baudis
2006-10-24 11:59 ` Jakub Narebski
2006-10-24 15:27 ` Petr Baudis
2006-10-24 17:17 ` Junio C Hamano
2006-10-24 17:26 ` Petr Baudis
2006-10-24 18:27 ` Junio C Hamano
2006-10-24 18:37 ` Jakub Narebski
2006-10-28 16:10 ` [PATCH] gitweb: Add "next" link to " Jakub Narebski
2006-10-28 19:00 ` Junio C Hamano
2006-10-29 1:50 ` Luben Tuikov
2006-10-29 1:58 ` Jakub Narebski
2006-10-29 2:04 ` Luben Tuikov
2006-10-29 2:10 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610241128.34532.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).