From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: Shawn Pearce <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] Make git-branch a builtin
Date: Tue, 24 Oct 2006 13:39:24 +0200 [thread overview]
Message-ID: <20061024113924.GC20017@pasky.or.cz> (raw)
In-Reply-To: <7vy7r6qkmg.fsf@assigned-by-dhcp.cox.net>
Dear diary, on Tue, Oct 24, 2006 at 08:43:35AM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> said that...
> Shawn Pearce <spearce@spearce.org> writes:
>
> >> > Wouldn't it make more sense to just include the full SHA1 of the
> >> > file we are deleting rather than the entire 131 line negative diff?
> >>
> >> How would you do "git apply -R" on something like that?
> >
> > Uh, you have the full SHA1 in the index line. So you just have to
> > reattach that blob to the named path... pretty simple actually.
>
> Bzzzt; wrong answer.
>
> Think of a future when you can shallowly clone near the tip of
> git repository that does not have shell-script git-branch.sh
> anymore. You cannot expect to already have the preimage of the
> patch in such a case. You would still want to be able to revert
> the change with "git apply -R".
Hmm, how is this argument not applying to binary diffs you can't revert
either?
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)
next prev parent reply other threads:[~2006-10-24 11:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 21:40 [PATCH] Make git-branch a builtin Lars Hjemli
2006-10-23 21:55 ` Shawn Pearce
2006-10-23 23:19 ` Petr Baudis
2006-10-23 23:44 ` Junio C Hamano
2006-10-24 5:44 ` Shawn Pearce
2006-10-24 6:43 ` Junio C Hamano
2006-10-24 6:55 ` Shawn Pearce
2006-10-24 11:39 ` Petr Baudis [this message]
2006-10-24 17:00 ` Junio C Hamano
2006-10-23 22:34 ` Junio C Hamano
2006-10-23 23:51 ` [PATCH] Git-branch: fix regression and style issues Lars Hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061024113924.GC20017@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).