From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: <git@vger.kernel.org>
Subject: [PATCH] xdiff: Match GNU diff behaviour when deciding hunk comment worthiness of lines
Date: Wed, 25 Oct 2006 02:28:55 +0200 [thread overview]
Message-ID: <20061025002855.4738.1088.stgit@machine.or.cz> (raw)
In-Reply-To: <7vmz7lfdwj.fsf@assigned-by-dhcp.cox.net>
This removes the '#' and '(' tests and adds a '$' test instead although I have
no idea what it is actually good for - but hey, if that's what GNU diff does...
Pasky only went and did as Junio sayeth.
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
xdiff/xemit.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/xdiff/xemit.c b/xdiff/xemit.c
index 714c563..4139d55 100644
--- a/xdiff/xemit.c
+++ b/xdiff/xemit.c
@@ -86,8 +86,7 @@ static void xdl_find_func(xdfile_t *xf,
if (len > 0 &&
(isalpha((unsigned char)*rec) || /* identifier? */
*rec == '_' || /* also identifier? */
- *rec == '(' || /* lisp defun? */
- *rec == '#')) { /* #define? */
+ *rec == '$')) { /* mysterious GNU diff's invention */
if (len > sz)
len = sz;
next prev parent reply other threads:[~2006-10-25 0:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-25 0:07 [PATCH] xdiff: Do not consider lines starting by # hunkworthy Petr Baudis
2006-10-25 0:16 ` Junio C Hamano
2006-10-25 0:28 ` Petr Baudis [this message]
2006-10-25 1:33 ` [PATCH] xdiff: Match GNU diff behaviour when deciding hunk comment worthiness of lines Horst H. von Brand
2006-10-25 2:18 ` Junio C Hamano
2006-10-25 0:17 ` [PATCH] xdiff: Do not consider lines starting by # hunkworthy Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061025002855.4738.1088.stgit@machine.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).