git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: Jakub Narebski <jnareb@gmail.com>,
	git@vger.kernel.org, ltuikov@yahoo.com
Subject: Re: [PATCH (amend)] gitweb: Slight visual improvements to commitdiff view
Date: Fri, 27 Oct 2006 03:47:40 +0200	[thread overview]
Message-ID: <20061027014740.GV20017@pasky.or.cz> (raw)
In-Reply-To: <7vu01qilg1.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Fri, Oct 27, 2006 at 03:42:06AM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> said that...
> Luben Tuikov <ltuikov@yahoo.com> writes:
> 
> > --- Jakub Narebski <jnareb@gmail.com> wrote:
> > ...
> >> Those changes might wait for proper refactoring of gitweb CSS (having 
> >> for example 8px padding in one place only).
> >
> > Excellent!  I'd like this explanation to be part of the
> > commit message if that patchset is committed to git.git.
> 
> I'd like that kind of explanation with the patch in a single
> message when it is ready to be applied, too.
> 
> I'll leave it up to you guys to decide if CSS refactoring should
> go in first (I personally feel it probably is the case, in which
> case this patch would need to be rebased I suspect).

We don't have any such patch, do we? So let anyone doing that patch take
this one into account and merge in whatever we have, I'd say.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1

      reply	other threads:[~2006-10-27  1:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-26 16:13 [PATCH] gitweb: Slight visual improvements to commitdiff view Jakub Narebski
2006-10-26 16:43 ` [PATCH (amend)] " Jakub Narebski
2006-10-26 23:34   ` Luben Tuikov
2006-10-26 23:50     ` Jakub Narebski
2006-10-27  0:39       ` Luben Tuikov
2006-10-27  1:42         ` Junio C Hamano
2006-10-27  1:47           ` Petr Baudis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061027014740.GV20017@pasky.or.cz \
    --to=pasky@suse.cz \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=junkio@cox.net \
    --cc=ltuikov@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).