From: Petr Baudis <pasky@suse.cz>
To: Jim Meyering <jim@meyering.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] cogito: Honor either post-commit script name; fail if both are executable
Date: Fri, 27 Oct 2006 04:05:49 +0200 [thread overview]
Message-ID: <20061027020549.GY20017@pasky.or.cz> (raw)
In-Reply-To: <874ptzhsjs.fsf@rho.meyering.net>
Hi!
Dear diary, on Fri, Oct 20, 2006 at 06:15:51PM CEST, I got a letter
where Jim Meyering <jim@meyering.net> said that...
> I promised this patch some time ago, made the changes,
> and then never sent them. This is slightly different
> from the current implementation in that it fails when both
> scripts are executable. Also, it factors out the script names and
> adds tests.
>
> Signed-off-by: Jim Meyering <jim@meyering.net>
I'm not sure I like this (of course, I always like additional tests,
though). The problem is that this loses a smooth upgrade path, things
suddenly break and you can't commit without having to think about fixing
your environment. We should always give users enough time for that with
deprecation warnings. So if we want to get rid of commit-post, we should
rather start printing deprecation warnings if commit-post exists, and in
few months cut commit-post off.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
next prev parent reply other threads:[~2006-10-27 2:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 16:15 [PATCH] cogito: Honor either post-commit script name; fail if both are executable Jim Meyering
2006-10-27 2:05 ` Petr Baudis [this message]
2006-10-27 7:41 ` Jim Meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061027020549.GY20017@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox