From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: Junio Hamano <junkio@cox.net>, Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH] gitweb: Add "next" link to commitdiff view
Date: Sat, 28 Oct 2006 18:10:36 +0200 [thread overview]
Message-ID: <200610281810.36892.jnareb@gmail.com> (raw)
In-Reply-To: <200610230037.57183.jnareb@gmail.com>
Jakub Narebski wrote:
> Add a kind of "next" view in the bottom part of navigation bar for
> "commitdiff" view.
>
> For commitdiff between two commits:
> (from: _commit_)
> For commitdiff for one single parent commit:
> (parent: _commit_)
> For commitdiff for one merge commit
> (merge: _commit_ _commit_ ...)
> For commitdiff for root (parentless) commit
> (initial)
> where _link_ denotes hyperlink. SHA1 is shortened to 7 characters on
> display, everything is perhaps unnecessary esc_html on display.
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
>
> Junio (and others), is it what you wanted? The idea was to change
> "commitdiff" view only in minimal way, and preserve similarity
> to "commit" format.
Any reasons not to accept this patch? I find it very useful.
The idea to use fixed string instead of shortened SHA-1 of commit
was abandoned after some discussion in this thread.
--
Jakub Narebski
next prev parent reply other threads:[~2006-10-28 16:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-22 22:37 [PATCH] gitweb: Add "next" link to commitdiff view Jakub Narebski
2006-10-22 22:43 ` Jakub Narebski
2006-10-22 23:16 ` Junio C Hamano
2006-10-22 23:41 ` Jakub Narebski
2006-10-23 22:08 ` [PATCH 2/1] gitweb: Use fixed string for "next" link in " Jakub Narebski
2006-10-23 23:21 ` Petr Baudis
2006-10-24 9:04 ` [PATCH 2/1 (amend)] " Jakub Narebski
2006-10-24 9:17 ` Junio C Hamano
2006-10-24 9:28 ` Jakub Narebski
2006-10-24 11:49 ` [PATCH 2/1] " Petr Baudis
2006-10-24 11:59 ` Jakub Narebski
2006-10-24 15:27 ` Petr Baudis
2006-10-24 17:17 ` Junio C Hamano
2006-10-24 17:26 ` Petr Baudis
2006-10-24 18:27 ` Junio C Hamano
2006-10-24 18:37 ` Jakub Narebski
2006-10-28 16:10 ` Jakub Narebski [this message]
2006-10-28 19:00 ` [PATCH] gitweb: Add "next" link to " Junio C Hamano
2006-10-29 1:50 ` Luben Tuikov
2006-10-29 1:58 ` Jakub Narebski
2006-10-29 2:04 ` Luben Tuikov
2006-10-29 2:10 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610281810.36892.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).