Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view

[Jakub Narebski <jnareb@gmail.com>]

Few other questions, probably to be adressed in the future patches, and 
not added to this one.

0. git-ls-tree and git-diff-tree without -z does quote not only !isprint 
characters like LF '\n' and non-space whitespace characters like TAB 
'\t' (and of course quoting characters '\' and '"'), but for example 
also UTF-8 characters. See for example git-ls-tree output for 
gitweb/test directory. This screws somewhat idea how we should treat 
filenames which are quoted.

[BTW. How git should deal with being deployed in the environment where 
filesystem pathnames coding might not be UTF-8, and console (terminal) 
coding might be not UTF-8?]


1. Current version doesn't display empty patches (i.e. pure rename and 
mode change combinations) and doesn't provide links to them from 
difftree. This is legacy of old /usr/bin/diff using code, which did not 
generated extended diff header, which is only output for "empty 
patches". Should we change this, or leave as is?

2. Schould we change syntax highlighting of chunk header line, namely 
changing slightly syntax coloring of "in which function are we" part of 
chunk header?

3. Should we make from-range/to-range in chunk header hyperlink to the 
start of given bunch of lines in appropriate file? Or perhaps to the 
middle of the bunch of lines? Or to first changed line (omitting 
context)?

-- 
Jakub Narebski