From: Jan Harkes <jaharkes@cs.cmu.edu>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: WARNING: THIS PATCH CAN BREAK YOUR REPO, was Re: [PATCH 2/3] Only repack active packs by skipping over kept packs.
Date: Mon, 30 Oct 2006 17:55:00 -0500 [thread overview]
Message-ID: <20061030225500.GG3617@delft.aura.cs.cmu.edu> (raw)
In-Reply-To: <7v3b95wjmg.fsf@assigned-by-dhcp.cox.net>
On Mon, Oct 30, 2006 at 01:59:03PM -0800, Junio C Hamano wrote:
> Jan Harkes <jaharkes@cs.cmu.edu> writes:
>
> > The following patch does fix the problem Nicolas reported, but for some
> > reason I'm still getting only 102 objects (only tags and the commits
> > they refer to?) with your test.
>
> One potential downside of this is that this makes an obscure but
> useful "gitk --unpacked" useless (robs performance).
>
> http://thread.gmane.org/gmane.comp.version-control.git/19197/focus=19207
If I use 'git fetch' followed later on by a 'git fetch -k', the result
from --unpacked would not include the unpacked objects created by the
first fetch. Although it may have been fast, it seems to be somewhat
counter-intuitive.
> But other than that, I think it is an Ok change. The original
> semantics of --unpacked (with or without "pretend as if objects
> in this pack are loose") were, eh, "strange".
Do you need a resend with a proper 'Signed-Off-By' line?
Jan
next prev parent reply other threads:[~2006-10-30 22:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 9:37 [PATCH 2/3] Only repack active packs by skipping over kept packs Shawn Pearce
2006-10-30 19:07 ` WARNING: THIS PATCH CAN BREAK YOUR REPO, was " Nicolas Pitre
2006-10-30 19:23 ` Shawn Pearce
2006-10-30 20:26 ` Shawn Pearce
2006-10-30 20:52 ` Jan Harkes
2006-10-30 21:07 ` Jan Harkes
2006-10-30 21:09 ` Shawn Pearce
2006-10-30 21:59 ` Junio C Hamano
2006-10-30 22:54 ` Junio C Hamano
2006-10-30 22:55 ` Jan Harkes [this message]
2006-10-30 23:24 ` Junio C Hamano
2006-10-31 1:37 ` [PATCH] Continue traversal when rev-list --unpacked finds a packed commit Jan Harkes
2006-10-31 1:47 ` Junio C Hamano
2006-10-31 2:17 ` Jan Harkes
2006-10-30 21:48 ` WARNING: THIS PATCH CAN BREAK YOUR REPO, was Re: [PATCH 2/3] Only repack active packs by skipping over kept packs Junio C Hamano
2006-10-30 21:55 ` Shawn Pearce
2006-10-30 22:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061030225500.GG3617@delft.aura.cs.cmu.edu \
--to=jaharkes@cs.cmu.edu \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).