From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] gitweb: Use git-for-each-ref to generate list of heads and/or tags
Date: Fri, 3 Nov 2006 04:26:32 +0100 [thread overview]
Message-ID: <200611030426.32734.jnareb@gmail.com> (raw)
In-Reply-To: <7vhcxhl0bh.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>> CHANGES IN OUTPUT: Before, if ref in refs/tags was tag pointing to
>> commit we used committer epoch as epoch for ref, and used tagger epoch
>> as epoch only for tag pointing to object of other type. If ref in
>> refs/tags was commit, we used committer epoch as epoch for ref (see
>> parse_ref; we sorted in gitweb by 'epoch' field).
>
> I think that behaviour was inconsistent and just silly. Using
> creatordate consistently is better so if the code generates what
> the commit log claims to, I think that is fine (I haven't looked
> at it deeply yet).
Well, I _could_ argue on the former behaviour, namely that we use
committerdate when available (when ref points to commit, or to tag
pointing to commit), and if it is not available we use taggerdate
if possible.
The latter is that we use always "creation" date.
--
Jakub Narebski
next prev parent reply other threads:[~2006-11-03 3:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-28 17:30 [PATCH] Documentation: Update information about <format> in git-for-each-ref Jakub Narebski
2006-10-28 20:33 ` Junio C Hamano
2006-10-28 21:23 ` Jakub Narebski
2006-11-01 8:25 ` Andreas Ericsson
2006-11-01 8:47 ` Junio C Hamano
2006-11-01 10:23 ` Andreas Ericsson
2006-11-01 15:30 ` Junio C Hamano
2006-11-01 15:48 ` Johannes Schindelin
2006-11-02 19:17 ` [PATCH 1/2] for-each-ref: "creator" and "creatordate" fields Jakub Narebski
2006-11-02 19:23 ` [PATCH 2/2] gitweb: Use git-for-each-ref to generate list of heads and/or tags Jakub Narebski
2006-11-03 2:40 ` Junio C Hamano
2006-11-03 3:26 ` Jakub Narebski [this message]
2006-11-03 2:40 ` [PATCH 1/2] for-each-ref: "creator" and "creatordate" fields Junio C Hamano
2006-11-03 3:27 ` Jakub Narebski
2006-10-28 20:42 ` [PATCH] Documentation: Update information about <format> in git-for-each-ref Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611030426.32734.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).