From: Kevin Shanahan <kmshanah@disenchant.net>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: Problem with git-apply?
Date: Sat, 4 Nov 2006 21:19:13 +1030 [thread overview]
Message-ID: <20061104104913.GD19667@cubit> (raw)
In-Reply-To: <7vu01f34bo.fsf@assigned-by-dhcp.cox.net>
On Sat, Nov 04, 2006 at 02:15:55AM -0800, Junio C Hamano wrote:
> Actually it was a small problem in the patch parsing code. Can
> you give this a try?
Yes, this patch works for me.
Cheers,
Kev.
> ---
> diff --git a/builtin-apply.c b/builtin-apply.c
> index 11397f5..db7cdce 100644
> --- a/builtin-apply.c
> +++ b/builtin-apply.c
> @@ -1043,10 +1043,14 @@ static int parse_single_patch(char *line
> * then not having oldlines means the patch is creation,
> * and not having newlines means the patch is deletion.
> */
> - if (patch->is_new < 0 && !oldlines)
> + if (patch->is_new < 0 && !oldlines) {
> patch->is_new = 1;
> - if (patch->is_delete < 0 && !newlines)
> + patch->old_name = NULL;
> + }
> + if (patch->is_delete < 0 && !newlines) {
> patch->is_delete = 1;
> + patch->new_name = NULL;
> + }
> }
>
> if (0 < patch->is_new && oldlines)
next prev parent reply other threads:[~2006-11-04 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-04 7:23 Problem with git-apply? Kevin Shanahan
2006-11-04 7:30 ` Shawn Pearce
2006-11-04 8:07 ` Kevin Shanahan
2006-11-04 9:26 ` Jakub Narebski
2006-11-04 10:12 ` Kevin Shanahan
2006-11-04 9:49 ` Junio C Hamano
2006-11-04 10:00 ` Junio C Hamano
2006-11-04 10:15 ` Junio C Hamano
2006-11-04 10:49 ` Kevin Shanahan [this message]
2006-11-04 16:27 ` Linus Torvalds
2006-11-04 18:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061104104913.GD19667@cubit \
--to=kmshanah@disenchant.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).