git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] gitweb: Use character or octal escape codes (and add span.cntrl) in esc_path
Date: Wed, 8 Nov 2006 19:56:19 +0100	[thread overview]
Message-ID: <200611081956.20251.jnareb@gmail.com> (raw)
In-Reply-To: <7vmz71u787.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> Instead of simply hiding control characters in esc_path by replacing
>> them with '?', use Character Escape Codes (CEC) i.e. alphabetic
>> backslash sequences like those found in C programming language and
>> many other languages influenced by it, such as Java and Perl.  If
>> control characted doesn't have corresponding character escape code,
>> use octal char sequence to escape it.
>>
>> Additionally use 'span' element with 'cntrl' attribute to mark escaped
>> control characters. Add style for span.cntrl in the CSS.
> 
> Would have preferred the 'span' thing to be part of [1/2]...

I've misunderstood you then. I'm sorry.

> Didn't I ask quot to be freestanding sub, not nested?  That
> would make UPR vs CEC experiments easier and more pleasant.

In what way having freestanding and not nested sub would "make
UPR vs CEC experiments easier and more pleasant"?

If it is important, I can send patch moving quot sub outside
esc_path (and perhaps also unq sub outside unquote), or send
corrected patch... or you can correct patch by hand...

-- 
Jakub Narebski

      reply	other threads:[~2006-11-08 18:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-08 10:47 [PATCH 0/2] Better unquoting of git quoted filenames; esc_path to escape pathnames for display Jakub Narebski
2006-11-08 10:48 ` [PATCH 1/2] gitweb: Better git-unquoting and gitweb-quoting of pathnames Jakub Narebski
2006-11-08 10:50 ` [PATCH 2/2] gitweb: Use character or octal escape codes (and add span.cntrl) in esc_path Jakub Narebski
2006-11-08 16:58   ` [PATCH 0/2] gitweb: New improved patchset view Jakub Narebski
2006-11-08 16:59     ` [PATCH 1/2] " Jakub Narebski
2006-11-08 18:27       ` Junio C Hamano
2006-11-08 18:57         ` Junio C Hamano
2006-11-08 19:04           ` Jakub Narebski
2006-11-08 18:41       ` [PATCH 1/2 (amend)] " Jakub Narebski
2006-11-08 17:00     ` [PATCH 2/2] gitweb: New improved formatting of chunk header in diff Jakub Narebski
2006-11-08 20:41       ` Junio C Hamano
2006-11-08 20:58         ` Jakub Narebski
2006-11-08 21:41           ` Junio C Hamano
2006-11-08 21:55             ` Jakub Narebski
2006-11-08 18:24   ` [PATCH 2/2] gitweb: Use character or octal escape codes (and add span.cntrl) in esc_path Junio C Hamano
2006-11-08 18:56     ` Jakub Narebski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611081956.20251.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).