From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.176.0/21 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 From: Jakub Narebski Subject: Re: [PATCH] gitweb: Atom feeds Date: Fri, 17 Nov 2006 12:36:18 +0100 Message-ID: <200611171236.19030.jnareb@gmail.com> References: <11635494363452-git-send-email-asf@boinkor.net> <7v4psysazy.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit NNTP-Posting-Date: Fri, 17 Nov 2006 11:35:21 +0000 (UTC) Cc: git@vger.kernel.org, Petr Baudis Return-path: Envelope-to: gcvg-git@gmane.org DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=PXx3gGovx38+ReegJ6p2NkECjALHMuU6fqQNolftk2asi2U3HHijb53Gsu5qA8FvzLHyt2mN25s2Lu3Y5OaKi3M/E3kOTWmM+uuKWrPIdlfMgA5QdFHdSEkqLjC9LizlOtKKcXPdsxgkh585U+vRnegNxmaI4Ks6RfWCbQpyglY= User-Agent: KMail/1.9.3 In-Reply-To: <7v4psysazy.fsf@assigned-by-dhcp.cox.net> Content-Disposition: inline Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gl1zz-0003MD-Mx for gcvg-git@gmane.org; Fri, 17 Nov 2006 12:35:12 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755694AbWKQLfA (ORCPT ); Fri, 17 Nov 2006 06:35:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933531AbWKQLfA (ORCPT ); Fri, 17 Nov 2006 06:35:00 -0500 Received: from ug-out-1314.google.com ([66.249.92.174]:23335 "EHLO ug-out-1314.google.com") by vger.kernel.org with ESMTP id S1755694AbWKQLfA (ORCPT ); Fri, 17 Nov 2006 06:35:00 -0500 Received: by ug-out-1314.google.com with SMTP id m3so672511ugc for ; Fri, 17 Nov 2006 03:34:58 -0800 (PST) Received: by 10.66.221.6 with SMTP id t6mr1895260ugg.1163763298241; Fri, 17 Nov 2006 03:34:58 -0800 (PST) Received: from host-81-190-24-209.torun.mm.pl ( [81.190.24.209]) by mx.google.com with ESMTP id e33sm2987615ugd.2006.11.17.03.34.57; Fri, 17 Nov 2006 03:34:58 -0800 (PST) To: Junio C Hamano , Andreas Fuchs Sender: git-owner@vger.kernel.org Junio C Hamano wrote: > Andreas Fuchs writes: > >> Jakub Narebski wrote: >>> Andreas Fuchs wrote: >>> >>>> * Wrap the commit message in 
>>> We use 
 in "commit" view if I remember correctly.
>>
>> That's ok for rendered HTML output, but in my experience, the way feed
>> readers interpret that ranges from "badly" to "not at all"; it's better
>> to stick to explicit structure hints only in feeds. /-:

True. "
" in RSS feed is better (I don't know if you can give CSS
for RSS, be it RSS 2.01 or Atom; rather not).

>> So, this is the only thing I haven't fixed in the attached patch (:

Good.

>> In addition to the above points, the attached patch emits a
>> Last-Changed: HTTP response header field, and doesn't compute the feed
>> body if the HTTP request type was HEAD. This helps keep the web server
>> load down for well-behaved feed readers that check if the feed needs
>> updating.

Very nice.

>> Hope you like it,
> 
> Seems sane to me.  Jakub, how do you like this one?  

I like it. Ack.

> If it looks  Ok to you, please arrange to include your one-liner
> that this depends on and forward a readily applicable patch with
> appropriate commit log message.

Which one liner? As far as I can see the patch does NOT use
href(-full=>1,...) but esc_url(...).

Perhaps this is for next patch.


BTW I have encountered something calles Atom Publishing Protocol (APP):
perhaps we should also add this in addition to currently used OPML.
-- 
Jakub Narebski
Torun, Poland