git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Vilz <niv@iaglans.de>
To: git@vger.kernel.org
Subject: following Documentation/howto/update-hook-example.txt
Date: Mon, 20 Nov 2006 00:10:45 +0100	[thread overview]
Message-ID: <20061119231044.GA31562@hermes.lan.home.vilz.de> (raw)

hello guys,

I tested the script mentioned in update-hook-example.txt and noticed,
that the following line in allowed-users

refs/heads/tmp/         *

and the if-clause above 

matchlen=$(expr "$1" : "$head_pattern")
if [ "$matchlen" == "${#1}" ]; then

does not recognize the header

refs/heads/tmp/blah

... so, all users trying to update or create branches named
tmp/<insert_fancy_name_here> are denied, because nothing matches.

also the example case in which linus should be allowed to push and
create branches bw/blah and bw/blupp doesn't work.

If I try following rule in allowed-users

refs/heads/tmp 		*

and someone tries to commit refs/heads/tmp, it works as intended.

This is at least in bash 3.1.2.5 ... (i tested that on my powerbook this
week end). Perhaps it worked in November 2005. I don't know which
version of bash was the latest then.

For all other examples in this document, it grants and denies pushing
and creating branches as intended.

I haven't tried the tag-case yet.... could be, that this also doesn't
work anymore.

Greetings
Nicolas

                 reply	other threads:[~2006-11-19 23:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061119231044.GA31562@hermes.lan.home.vilz.de \
    --to=niv@iaglans.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).