From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: Re: Adding glob support to remotes
Date: Thu, 23 Nov 2006 08:44:27 +0000 [thread overview]
Message-ID: <200611230844.29061.andyparkins@gmail.com> (raw)
In-Reply-To: <7v3b8bryt6.fsf@assigned-by-dhcp.cox.net>
On Wednesday 2006 November 22 20:50, Junio C Hamano wrote:
> I do not understand and that is why I do not understand why you
> would need to touch check-ref-format.
The problem is that I didn't want to call git-ls-remote in git-parse-remote,
as git-parse-remote doesn't know about $uploadpack or what the actual remote
in use is. It seemed fairly intrusive to completely alter the functions in
git-parse-remote; which is obviously a set of library functions.
Instead I did the expansion in git-fetch.sh. Unfortunately that meant
disabling the check-ref-format call in canon_refs_list_for_fetch.
> point at" is to ask ls-remote, and if you do one ls-remote
> upfront then all you need to do here is a single grep.
I understand now. I'll look again at this tonight and send a further patch.
Andy
--
Dr Andy Parkins, M Eng (hons), MIEE
prev parent reply other threads:[~2006-11-23 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 9:04 Adding glob support to remotes Andy Parkins
2006-11-22 12:56 ` Junio C Hamano
2006-11-22 14:41 ` Andy Parkins
2006-11-22 20:50 ` Junio C Hamano
2006-11-23 8:44 ` Andy Parkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611230844.29061.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).