From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 3/3] git-fetch: allow glob pattern in refspec
Date: Thu, 23 Nov 2006 08:55:02 +0000 [thread overview]
Message-ID: <200611230855.04124.andyparkins@gmail.com> (raw)
In-Reply-To: <7vzmaik4mi.fsf@assigned-by-dhcp.cox.net>
On Thursday 2006 November 23 07:24, Junio C Hamano wrote:
> * Andy, I think this does the same thing as you wanted to do,
> but is cleaner implementation-wise and also at the concept
It certainly is. Looking at your implementation I see that I was worrying
unnecessarily about passing extra globals/parameters to git-parse-remote.
Your version is much better than mine; and I see that noone else calls
get_remote_refs_for_fetch anyway.
> level, to pretend as if the user listed the expanded form in
> the configuration. I deliberately decided not to apply the
> wildcard expansion on refspecs that came from command line,
> but if we wanted to we can move the expand_refs_wildcard call
> a few lines down to make it also apply to them.
That's probably the most sensible method. Using globs on the command line
could get people into trouble if they accidentally hit a shell expansion.
Andy
--
Dr Andy Parkins, M Eng (hons), MIEE
next prev parent reply other threads:[~2006-11-23 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-23 7:24 [PATCH 3/3] git-fetch: allow glob pattern in refspec Junio C Hamano
2006-11-23 8:55 ` Andy Parkins [this message]
2006-11-27 18:14 ` Michael Loeffler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611230855.04124.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).