git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yann Dirson <ydirson@altern.org>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: GIT list <git@vger.kernel.org>
Subject: [PATCH 4/4] Bomb out when --ack and --sign are both passed to "refresh".
Date: Fri, 24 Nov 2006 00:17:12 +0100	[thread overview]
Message-ID: <20061123231708.9769.53781.stgit@gandelf.nowhere.earth> (raw)
In-Reply-To: <20061123230721.9769.38403.stgit@gandelf.nowhere.earth>


Old behaviour was silently ignoring --ack, which could be confusing.

Signed-off-by: Yann Dirson <ydirson@altern.org>
---

 stgit/commands/refresh.py |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/stgit/commands/refresh.py b/stgit/commands/refresh.py
index ea0fe6f..aa5ff78 100644
--- a/stgit/commands/refresh.py
+++ b/stgit/commands/refresh.py
@@ -107,6 +107,8 @@ def func(parser, options, args):
 
     if options.sign:
         sign_str = 'Signed-off-by'
+        if options.ack:
+            raise CmdException, '--ack and --sign were both specified'
     elif options.ack:
         sign_str = 'Acked-by'

  parent reply	other threads:[~2006-11-23 23:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-23 23:16 [PATCH 0/4] Series short description Yann Dirson
2006-11-23 23:16 ` [PATCH 1/4] Make Series::patch_applied public Yann Dirson
2006-11-23 23:16 ` [PATCH 2/4] Allows to refresh a non-top applied patch Yann Dirson
2006-11-23 23:17 ` [PATCH 3/4] Optimize stg goto in the pop case Yann Dirson
2006-11-23 23:17 ` Yann Dirson [this message]
2006-11-24 15:37 ` [PATCH 0/4] Series short description Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061123231708.9769.53781.stgit@gandelf.nowhere.earth \
    --to=ydirson@altern.org \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).