From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/10] Teach git-completion.bash how to complete git-merge.
Date: Mon, 27 Nov 2006 15:12:36 -0500 [thread overview]
Message-ID: <20061127201236.GA7331@spearce.org> (raw)
In-Reply-To: <7vlklwhffb.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
>
> > +__git_merge_strategies ()
> > +{
> > + sed -n "/^all_strategies='/{
> > + s/^all_strategies='//
> > + s/'//
> > + p
> > + q
> > + }" "$(git --exec-path)/git-merge"
> > +}
> > +
>
> Shouldn't we load and compute this once and keep the result in a
> variable (say $__git_merge_strategies)?
Sure. See my latest 4 patch series. :-)
--
prev parent reply other threads:[~2006-11-27 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-27 8:40 [PATCH 1/10] Teach git-completion.bash how to complete git-merge Shawn O. Pearce
2006-11-27 19:12 ` Junio C Hamano
2006-11-27 20:12 ` Shawn Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061127201236.GA7331@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).