git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Trim hint printed when gecos is empty.
Date: Tue, 28 Nov 2006 14:03:35 +0000	[thread overview]
Message-ID: <200611281403.36370.andyparkins@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0611281426311.30004@wbgn013.biozentrum.uni-wuerzburg.de>

On Tuesday 2006 November 28 13:28, Johannes Schindelin wrote:

> No. As has been often said, a signoff _has_ to be a conscious act, or else
> it will lose its meaning.

I'm not suggesting that a project integrator would have that switch on, but 
for me, in my own repository, where I am the only person writing patches, 
what possible case is there that I won't sign off?

> Once you are reasonably convinced you want to sign off on that commit,

I am always convinced.  Perhaps I am doing wrong - please explain to me under 
what circumstance I would /not/ want to sign off on a commit.  (assuming I am 
acting merely as a developer on a project, I am not accepting patches from 
anyone but me).

> just add "-s" to git-commit. And if you forgot, fix it by "git commit -s
> --amend". (Note that this is another nice example why "-a" by default
> would be wrong, wrong, wrong.)

I don't see what one has to do with the other.  There are good arguments for 
not having "-a" default, but signing off isn't one of them.


Andy
-- 
Dr Andy Parkins, M Eng (hons), MIEE

  reply	other threads:[~2006-11-28 14:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-28 10:27 [PATCH] Trim hint printed when gecos is empty Han-Wen Nienhuys
2006-11-28 10:52 ` Han-Wen Nienhuys
2006-11-28 11:15   ` Jakub Narebski
2006-11-28 11:46     ` Andy Parkins
2006-11-28 13:28       ` Johannes Schindelin
2006-11-28 14:03         ` Andy Parkins [this message]
2006-11-28 14:40           ` Johannes Schindelin
2006-11-28 15:06             ` Andy Parkins
2006-11-28 15:31               ` Shawn Pearce
2006-11-28 18:29               ` Junio C Hamano
2006-11-29  9:29                 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611281403.36370.andyparkins@gmail.com \
    --to=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).