git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Trim hint printed when gecos is empty.
Date: Tue, 28 Nov 2006 15:06:50 +0000	[thread overview]
Message-ID: <200611281506.53518.andyparkins@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0611281536230.30004@wbgn013.biozentrum.uni-wuerzburg.de>

On Tuesday 2006 November 28 14:40, Johannes Schindelin wrote:

> You are probably different than me. What with my track record, I _trust_
> my patches to be not perfect at all. Nevertheless, I commit here and now,
> and usually I regroup the commits into a nice patch (series) (AKA poor
> man's StGit).

I'm certainly not perfect, nor would I ever claim to be.  Perhaps I have 
misunderstood the purpose of the Signed-Off line.  I had understood it was a 
legal tool to trace the provenance of a patch - not to sign off on it being 
bug free (which surely is impossible).

Since I know that I, and I alone wrote that patch, I can sign off on it 
regardless of it being any good technically.

This is in agreement with my understanding of the 
Documentation/SubmittingPatches file included with git.

"The sign-off is a simple line at the end of the explanation for
the patch, which certifies that you wrote it or otherwise have
the right to pass it on as a open-source patch."

> So I will never need something like you suggest. Having said that, if you
> think it is best for you to mark every commit as signed-off-by you, just
> add an alias:
>
> 	git repo-config --global alias.c "commit -s"

That requires that I introduce a new command; I want the existing command to 
do The Right Thing.  Also; I certainly wouldn't want it global, as I said in 
my original message - this is a per-project choice.  Some projects don't have 
Signed-Off lines, so there is no point there.

Ideally, I'd be able to do
        git repo-config alias.commit "commit -s"
Just as I can with shell commands.


Andy
-- 
Dr Andy Parkins, M Eng (hons), MIEE

  reply	other threads:[~2006-11-28 15:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-28 10:27 [PATCH] Trim hint printed when gecos is empty Han-Wen Nienhuys
2006-11-28 10:52 ` Han-Wen Nienhuys
2006-11-28 11:15   ` Jakub Narebski
2006-11-28 11:46     ` Andy Parkins
2006-11-28 13:28       ` Johannes Schindelin
2006-11-28 14:03         ` Andy Parkins
2006-11-28 14:40           ` Johannes Schindelin
2006-11-28 15:06             ` Andy Parkins [this message]
2006-11-28 15:31               ` Shawn Pearce
2006-11-28 18:29               ` Junio C Hamano
2006-11-29  9:29                 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611281506.53518.andyparkins@gmail.com \
    --to=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).