From: Shawn Pearce <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: Re: EGIT unpackedreadr problem
Date: Sat, 2 Dec 2006 21:25:13 -0500 [thread overview]
Message-ID: <20061203022513.GB26668@spearce.org> (raw)
In-Reply-To: <200612030200.13857.robin.rosenberg@dewire.com>
Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> Subject: [PATCH] Utility to show a log.
Thanks. This is somewhat handy so I've applied the utility program.
Like your other patch to Commit class this one had some whitespace
issues. In the future could you apply the Eclipse formatter (using
the Java Conventions style) to the source before genererating a diff?
> Not sure what's going on. The UnpackedReader "looks" like it does
> the equivalent of what it did before,but apparently it isn't.
Yea... I broke the legacy header parsing in 42691339.
The breakage actually showed up in one of the unit tests
(test009_CreateCommitOldFormat) but I didn't notice it before
pushing the changes out as I failed to run the entire unit test
suite first. Whoops.
I found it and fixed it in f70704f9. The issue was we were copying
the remaining data from the Inflater ontop of the data we had
already decompressed out for the header; this meant that we lost the
leading bytes of each object. I just neglated to push the fix out.
Double whoops.
--
prev parent reply other threads:[~2006-12-03 2:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-03 1:00 EGIT unpackedreadr problem Robin Rosenberg
2006-12-03 2:25 ` Shawn Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061203022513.GB26668@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox