From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: Shawn Pearce <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [EGIT PATCH] Convert author and comment on demand.
Date: Sun, 3 Dec 2006 13:18:32 +0100 [thread overview]
Message-ID: <200612031318.33332.robin.rosenberg@dewire.com> (raw)
In-Reply-To: <20061203021655.GA26668@spearce.org>
söndag 03 december 2006 03:16 skrev Shawn Pearce:
> Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> > This sppeds up reading commits a lot by only store the byte
> > array data when reading commits.
>
> Thanks. I was working on something similar but did not have
> a chance to finish it. I've applied your patch instead.
>
> > + try {
> > + BufferedReader br=new BufferedReader(new InputStreamReader(new
> > ByteArrayInputStream(raw)));
> > + String n=br.readLine();
>
> Something's wrong with your mail client... the patch was mangled.
Not really, only the user. KMail by default wraps lines and I didn't turn that
off before sending. Usually I send patches just using stg mail, but this time
I used git-format-patch and kmail. Generatig attachements may be better (next
time).
next prev parent reply other threads:[~2006-12-03 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-03 0:45 [EGIT PATCH] Convert author and comment on demand Robin Rosenberg
2006-12-03 2:16 ` Shawn Pearce
2006-12-03 12:18 ` Robin Rosenberg [this message]
2006-12-03 12:34 ` Jakub Narebski
2006-12-03 18:08 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612031318.33332.robin.rosenberg@dewire.com \
--to=robin.rosenberg@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).