* [PATCH] gitweb: Fix Atom feed <logo>: it is $logo, not $logo_url
@ 2006-12-04 13:09 Jakub Narebski
0 siblings, 0 replies; only message in thread
From: Jakub Narebski @ 2006-12-04 13:09 UTC (permalink / raw)
To: git
Fix contents of Atom feed <logo> element; it should be URL
of $logo, not URL pointed by logo link.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Do anyone use Atom feed logo? This error was from the beginning of Atom
feed generation in git.git version of gitweb, and nobody complained.
I wonder why it is <logo>URL</logo>, and not <logo href="URL" />...
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 093bd72..ffe8ce1 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4282,7 +4282,7 @@ XML
}
if (defined $logo_url) {
# not twice as wide as tall: 72 x 27 pixels
- print "<logo>" . esc_url($logo_url) . "</logo>\n";
+ print "<logo>" . esc_url($logo) . "</logo>\n";
}
if (! %latest_date) {
# dummy date to keep the feed valid until commits trickle in:
--
1.4.4.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-12-04 13:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-04 13:09 [PATCH] gitweb: Fix Atom feed <logo>: it is $logo, not $logo_url Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).