From: Eric Wong <normalperson@yhbt.net>
To: Han-Wen Nienhuys <hanwen@xs4all.nl>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Install git-sh-setup.sh into $(prefix)/share/git-core. Call with explicit path.
Date: Fri, 8 Dec 2006 11:37:18 -0800 [thread overview]
Message-ID: <20061208193718.GA11906@soma> (raw)
In-Reply-To: <elc6g3$v1m$1@sea.gmane.org>
Han-Wen Nienhuys <hanwen@xs4all.nl> wrote:
>
> git-sh-setup isn't a 'normal' binary, in that it should be called by
> bash only and not run in a subshell. Therefore, it should not be installed
> in a executable directory, but rather in $prefix/share/git-core/
This seems to break existing hooks, or at least old repositories can
be stuck using an old version of git-sh-setup in those hooks.
You could to add GIT_datadir to PATH before invoking hooks for existing
ones to work, or write some sort of conversion script...
> ---
> Makefile | 10 ++++++++--
> git-am.sh | 2 +-
> git-applymbox.sh | 2 +-
> git-applypatch.sh | 2 +-
> git-bisect.sh | 2 +-
> git-checkout.sh | 2 +-
> git-clean.sh | 2 +-
> git-commit.sh | 2 +-
> git-fetch.sh | 2 +-
> git-instaweb.sh | 2 +-
> git-lost-found.sh | 2 +-
> git-merge.sh | 2 +-
> git-pull.sh | 2 +-
> git-quiltimport.sh | 2 +-
> git-rebase.sh | 2 +-
> git-repack.sh | 2 +-
> git-request-pull.sh | 2 +-
> git-reset.sh | 2 +-
> git-resolve.sh | 2 +-
> git-revert.sh | 2 +-
> git-tag.sh | 2 +-
> git-verify-tag.sh | 2 +-
> 22 files changed, 29 insertions(+), 23 deletions(-)
You shoudl probably change these, too:
templates/hooks--pre-applypatch:. git-sh-setup
templates/hooks--applypatch-msg:. git-sh-setup
--
next prev parent reply other threads:[~2006-12-08 19:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 17:13 [PATCH] Install git-sh-setup.sh into $(prefix)/share/git-core. Call with explicit path Han-Wen Nienhuys
2006-12-08 19:11 ` Nguyen Thai Ngoc Duy
2006-12-08 20:50 ` Han-Wen Nienhuys
2006-12-08 19:37 ` Eric Wong [this message]
2006-12-08 20:45 ` Junio C Hamano
2006-12-09 13:08 ` Han-Wen Nienhuys
2006-12-09 21:35 ` Junio C Hamano
2006-12-09 23:40 ` Han-Wen Nienhuys
2006-12-10 0:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061208193718.GA11906@soma \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=hanwen@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).