git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: fork0@t-online.de (Alex Riesen)
To: Han-Wen Nienhuys <hanwen@xs4all.nl>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow building GIT in a different directory from the source directory
Date: Sat, 9 Dec 2006 02:16:39 +0100	[thread overview]
Message-ID: <20061209011639.GA8010@steel.home> (raw)
In-Reply-To: <elc6j2$vej$1@sea.gmane.org>

Han-Wen Nienhuys, Fri, Dec 08, 2006 18:15:25 +0100:
> -my %pm = ('Git.pm' => '$(INST_LIBDIR)/Git.pm');
> +
> +$src_prefix = '';
> +if (!($ENV{'PERL_SRCDIR'} eq "")) {
> +    $src_prefix = $ENV{'PERL_SRCDIR'} . "/"
> +}

Hurts my eyes :)

    $src_prefix = defined($ENV{PERL_SRCDIR}) ?  "$ENV{PERL_SRCDIR}/": '';

could be shorter, unless you want (you do) strict syntax check.

  parent reply	other threads:[~2006-12-09  1:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-08 17:15 [PATCH] Allow building GIT in a different directory from the source directory Han-Wen Nienhuys
2006-12-08 17:44 ` Jakub Narebski
2006-12-08 18:14   ` Han-Wen Nienhuys
2006-12-09  1:16 ` Alex Riesen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-12-11 13:56 Han-Wen Nienhuys
2006-12-12  9:03 ` Junio C Hamano
2006-12-12 11:50   ` Han-Wen Nienhuys
2006-12-12 18:55     ` Johannes Schindelin
2006-12-13  9:28       ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061209011639.GA8010@steel.home \
    --to=fork0@t-online.de \
    --cc=git@vger.kernel.org \
    --cc=hanwen@xs4all.nl \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).